Skip to content

chore(ci): bring back node_modules caching behavior and remove extraneous cache generation#8333

Merged
mimecuvalo merged 2 commits intomainfrom
mime/ci-caching
Mar 24, 2026
Merged

chore(ci): bring back node_modules caching behavior and remove extraneous cache generation#8333
mimecuvalo merged 2 commits intomainfrom
mime/ci-caching

Conversation

@mimecuvalo
Copy link
Copy Markdown
Member

@mimecuvalo mimecuvalo commented Mar 24, 2026

Couple things going on here to unpack:

  • this reverts chore(ci): reduce cache bloat by saving only on main #8204
  • b/c that was reverted our CI times went from 4/5 min back to 8min because we had to recompile things during setup.yml in the yarn step. this was adding ~2min back to each CI action.
  • we were hitting our 10GB limit before but the majority of that was because we were adding -${{github.sha}} to a bunch of our tooling caches, creating a bunch of extra cache entries for no reason

Fixes:

  • removes the ${{github.sha}} from the key, unnecessary.
  • caches node_modules again to save CI time again
  • I increased our org cache limit to 20GB for now, we only pay for actual usage, things get auto-purged after 7 days anyway
Screenshot 2026-03-24 at 14 26 19
  • i'll manually clear some cache entries as well

@huppy-bot huppy-bot bot added the improvement Product improvement label Mar 24, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
examples Ready Ready Preview Mar 24, 2026 2:27pm
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
analytics Ignored Ignored Mar 24, 2026 2:27pm
chat-template Ignored Ignored Mar 24, 2026 2:27pm
tldraw-docs Ignored Ignored Mar 24, 2026 2:27pm
tldraw-shader Ignored Ignored Mar 24, 2026 2:27pm
workflow-template Ignored Ignored Mar 24, 2026 2:27pm

Request Review

@mimecuvalo mimecuvalo changed the title chore(ci): revert #8204 cache behavior and remove sha keys chore(ci): bring back node_modules caching behavior and remove extraneous cache generation Mar 24, 2026
@mimecuvalo mimecuvalo added this pull request to the merge queue Mar 24, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2026
@mimecuvalo mimecuvalo added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit f354288 Mar 24, 2026
24 checks passed
@mimecuvalo mimecuvalo deleted the mime/ci-caching branch March 24, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Product improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant