i18n: add warning if falling back to default translation#8164
Merged
mimecuvalo merged 1 commit intomainfrom Mar 5, 2026
Merged
i18n: add warning if falling back to default translation#8164mimecuvalo merged 1 commit intomainfrom
mimecuvalo merged 1 commit intomainfrom
Conversation
huppy-bot
bot
added
the
other
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| const messages = translation?.messages ?? DEFAULT_TRANSLATION | ||
| if (!translation?.messages) { | ||
| console.warn('No translation messages found, falling back to default translation.') | ||
| } |
There was a problem hiding this comment.
Console warning fires on every render cycle
Medium Severity
The console.warn is placed directly in the render body of the useTranslation hook rather than inside a useEffect. This means it fires on every single render of every component calling useTranslation() when the fallback condition is met. Given this hook is used in many components across the codebase, this will spam the console with repeated warnings on each re-render, making it noisy and potentially impacting dev-mode performance.
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
bah, whoops, followup again #8164 (review) ### Change type - [ ] `bugfix` - [ ] `improvement` - [ ] `feature` - [ ] `api` - [x] `other` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: only changes when the fallback `console.warn` fires, moving it out of render and preventing repeated warnings on re-renders. > > **Overview** > Moves the "falling back to default translation" warning in `useTranslation` from render-time to a `useEffect` keyed on `translation?.messages`, so the warning only emits when messages are missing (or change to missing) rather than on every render. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 87ae187. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to #8011
tiny nit feedback from @MitjaBezensek
Change type
bugfiximprovementfeatureapiotherNote
Low Risk
Low risk: adds a
console.warnwhenuseTranslationcannot find translation messages, which may increase log noise but does not change translation lookup behavior.Overview
useTranslationnow emits aconsole.warnwhen no translation messages are present and it falls back toDEFAULT_TRANSLATION, making missing/incorrect translation provider setup more visible during development.Written by Cursor Bugbot for commit cd95cda. This will update automatically on new commits. Configure here.