fix: correct efficient zoom threshold for scaled shapes#8040
Merged
steveruizok merged 1 commit intomainfrom Feb 24, 2026
Merged
fix: correct efficient zoom threshold for scaled shapes#8040steveruizok merged 1 commit intomainfrom
steveruizok merged 1 commit intomainfrom
Conversation
The zoom threshold for hiding shadows (notes) and forcing solid rendering (arrows, geo shapes) was using `scale * 0.25`, which made the threshold higher for larger-scale shapes. This is backwards — a dynamic-sized note with scale 20 at 5% zoom looks the same as a scale-1 note at 100%, so it should keep its shadow/dashes. Changed to `0.25 / scale` so the threshold accounts for visual size. Closes #7999 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
steveruizok
added a commit
that referenced
this pull request
Feb 27, 2026
Add 12 new entries from PRs merged since v4.4.0: - Featured: click-through on transparent image pixels (#7942) - API: enum-to-const-object refactor (#8084) - Improvements: SVG sanitizer (#7896), save-on-blur (#8037) - Bug fixes: cross-origin download (#8090), zero-size draw (#8067), rich text toolbar cleanup (#8050), zoom threshold (#8040), selection foreground fallback (#8011), sticky note SVG shadow (#7934), arrow frame clamping (#7932), zero pressure draw (#5693)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix dynamic-size shapes losing their visual detail (shadows, dashes) too aggressively when zoomed out, this PR corrects the efficient zoom threshold formula for scaled shapes.
The threshold was using
scale * 0.25, which made detail disappear sooner for larger-scale shapes — the opposite of what's correct. A note created at 5% zoom with scale 20 looks the same on screen as a scale-1 note at 100% zoom, so it should keep its shadow and dashes. Changed to0.25 / scaleso the threshold accounts for the shape's visual size.Closes #7999
Change type
bugfixTest plan
Release notes