ci: speed up circular dependency checks#8017
Merged
mimecuvalo merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Document and implement a dynamic batching strategy for tldraw circular dependency scans to avoid plugin crashes while reducing runtime significantly. Co-authored-by: Cursor <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
mimecuvalo
temporarily deployed
to
bemo-canary
GitHub Actions
Inactive
mimecuvalo
temporarily deployed
to
e2e-dotcom
GitHub Actions
Inactive
huppy-bot
bot
added
the
other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i originally removed these but they're necessary to keep things speedy
Summary
vite-plugin-circular-dependencyui/componentsandui/contextseparate to avoid pluginInvalid array lengthcrashesFollow-up to #8003.
Related to #7935 and #2458.
Change type
otherTest plan
yarn check-circular-depstime yarn check-circular-depsand verify improved runtimeMade with Cursor
Note
Low Risk
Build-time CI script changes only; main risk is false negatives/positives if the new include batching misses files or alters scan boundaries.
Overview
Speeds up
yarn check-circular-depsby changingtldraw’s include patterns from per-scope scans to filesystem-discovered batches, scanning all non-UI scopes together while keepingui/componentsandui/contextisolated to avoidvite-plugin-circular-dependency“Invalid array length” crashes.Also runs each include-set check via a small worker queue with bounded concurrency (up to 2 for
tldraw) instead of strictly serial execution, improving CI/local runtime without reducing coverage.Written by Cursor Bugbot for commit f2393ce. This will update automatically on new commits. Configure here.