feat(scribble): add complete state to scribble lifecycle#7760
Merged
steveruizok merged 1 commit intomainfrom Jan 28, 2026
Merged
feat(scribble): add complete state to scribble lifecycle#7760steveruizok merged 1 commit intomainfrom
steveruizok merged 1 commit intomainfrom
Conversation
Add a 'complete' state to scribbles to represent strokes that are done being drawn but not yet fading. This provides better stroke termination for the laser tool, applying taper effects when the user lifts the pointer. - Add 'complete' to TL_SCRIBBLE_STATES enum - Add ScribbleManager.complete() method to mark scribbles complete - Update TldrawScribble to taper on complete state - Call complete() from Lasering state on pointer up
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
steveruizok
temporarily deployed
to
bemo-canary
GitHub Actions
Inactive
steveruizok
temporarily deployed
to
e2e-dotcom
GitHub Actions
Inactive
Contributor
|
API Changes Check Passed Great! The PR description now includes the required "### API changes" section. This helps reviewers and SDK users understand the impact of your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to provide better stroke termination for the laser tool, this PR adds a 'complete' state to the scribble lifecycle. This state represents scribbles that are done being drawn but not yet fading, allowing taper effects to be applied when the user lifts the pointer.
This builds on the telestrator pattern introduced in #7681.
Change type
improvementTest plan
API changes
completetoTL_SCRIBBLE_STATESenumScribbleManager.complete(id)method to mark a scribble as completeRelease notes