refactor(editor): make SpatialIndexManager internal#7699
Merged
MitjaBezensek merged 2 commits intomainfrom Jan 16, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
Contributor
|
API Changes Check Passed Great! The PR description now includes the required "### API changes" section. This helps reviewers and SDK users understand the impact of your changes. |
MitjaBezensek
temporarily deployed
to
bemo-canary
GitHub Actions
Inactive
MitjaBezensek
temporarily deployed
to
e2e-dotcom
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7676. I've reconsidered and made the spatial index private.
This PR makes the SpatialIndexManager internal to the editor rather than part of the public API. The spatial index is an implementation detail used for efficient shape queries.
Changes:
SpatialIndexManagerclass as@internaleditor.spatialIndexpublic property (nowprivate _spatialIndex)editor.getShapeIdsInsideBounds()as@internalThe public API for shape queries remains
editor.getShapeAtPoint()andeditor.getShapesAtPoint(), which handle edge cases like frame labels being outside their bounds.Change type
apiAPI changes
editor.spatialIndexproperty from public APIeditor.getShapeIdsInsideBounds()from@publicto@internalSpatialIndexManagerclass from@publicto@internalTest plan
Release notes
editor.spatialIndexfrom public APINote
Makes spatial indexing an internal implementation detail and removes it from the public API.
SpatialIndexManageras@internal; update class docs accordinglyeditor.spatialIndex; introduce privateeditor._spatialIndexand update usages in hit-testing and bounds querieseditor.getShapeIdsInsideBounds()as@internaland clarify its bounds-only behavioreditor.getShapeAtPoint()/editor.getShapesAtPoint()Written by Cursor Bugbot for commit f366bfb. This will update automatically on new commits. Configure here.