perf(utils): implement adaptive FPS maximum variant#6497
Merged
mimecuvalo merged 2 commits intomime/adaptive-fpsfrom Jul 25, 2025
Merged
perf(utils): implement adaptive FPS maximum variant#6497mimecuvalo merged 2 commits intomime/adaptive-fpsfrom
mimecuvalo merged 2 commits intomime/adaptive-fpsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
3 tasks
mimecuvalo
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // After collecting enough measurements, set target to the maximum detected FPS | ||
| if (measurementCount >= DETECTION_MEASUREMENTS) { | ||
| targetFps = maxDetectedFps | ||
| targetTimePerFrame = getTargetTimePerFrame(targetFps) |
There was a problem hiding this comment.
Bug: FPS Detection Overwrites Manual Settings
After the initial FPS detection phase (10 measurements), the system continuously overrides targetFps by resetting it to maxDetectedFps on every subsequent call to updateTargetFps(). This immediately overrides any manual setTargetFps() calls, contradicting documentation that implies manual settings are only overridden if detection is 'still active'. It also leads to redundant assignments of targetFps and targetTimePerFrame even when maxDetectedFps has not changed.
Locations (1)
steveruizok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variant on #6470 (this is based on that PR)
@MitjaBezensek wdyt?
Change type
improvementTest plan
Release notes