Fix: Prioritize instance-level embedDefinitions over static legacy field

cursoragent · cursoragent · commit 97986fd932de · 2026-02-28T13:48:39.000Z
Make embedDefinitions optional in EmbedShapeOptions and invert priority order in getEmbedDefs() to check instance options first, then legacy static field, then default. This ensures configure() API works correctly even when deprecated setEmbedDefinitions() has been called globally.
diff --git a/packages/tldraw/api-report.api.md b/packages/tldraw/api-report.api.md
@@ -1394,7 +1394,7 @@ export interface EmbedDefinition {
 
 // @public (undocumented)
 export interface EmbedShapeOptions {
-    readonly embedDefinitions: readonly TLEmbedDefinition[];
+    readonly embedDefinitions?: readonly TLEmbedDefinition[];
 }
 
 // @public
diff --git a/packages/tldraw/src/lib/shapes/embed/EmbedShapeUtil.tsx b/packages/tldraw/src/lib/shapes/embed/EmbedShapeUtil.tsx
@@ -39,7 +39,7 @@ const getSandboxPermissions = (permissions: TLEmbedShapePermissions) => {
 /** @public */
 export interface EmbedShapeOptions {
 	/** The embed definitions to use for this shape util. */
-	readonly embedDefinitions: readonly TLEmbedDefinition[]
+	readonly embedDefinitions?: readonly TLEmbedDefinition[]
 }
 
 /** @public */
@@ -48,9 +48,7 @@ export class EmbedShapeUtil extends BaseBoxShapeUtil<TLEmbedShape> {
 	static override props = embedShapeProps
 	static override migrations = embedShapeMigrations
 
-	override options: EmbedShapeOptions = {
-		embedDefinitions: DEFAULT_EMBED_DEFINITIONS,
-	}
+	override options: EmbedShapeOptions = {}
 
 	override canEditWhileLocked(shape: TLEmbedShape) {
 		const result = this.getEmbedDefinition(shape.props.url)
@@ -66,7 +64,11 @@ export class EmbedShapeUtil extends BaseBoxShapeUtil<TLEmbedShape> {
 	}
 
 	private getEmbedDefs(): readonly TLEmbedDefinition[] {
-		return EmbedShapeUtil.legacyEmbedDefinitions ?? this.options.embedDefinitions
+		return (
+			this.options.embedDefinitions ??
+			EmbedShapeUtil.legacyEmbedDefinitions ??
+			DEFAULT_EMBED_DEFINITIONS
+		)
 	}
 
 	getEmbedDefinitions(): readonly TLEmbedDefinition[] {

Original file line number	Diff line number	Diff line change
`@@ -1394,7 +1394,7 @@ export interface EmbedDefinition {`
`1394`	`1394`
`1395`	`1395`	`// @public (undocumented)`
`1396`	`1396`	`export interface EmbedShapeOptions {`
`1397`		`- readonly embedDefinitions: readonly TLEmbedDefinition[];`
	`1397`	`+ readonly embedDefinitions?: readonly TLEmbedDefinition[];`
`1398`	`1398`	`}`
`1399`	`1399`
`1400`	`1400`	`// @public`