Skip to content
This repository was archived by the owner on Apr 19, 2025. It is now read-only.

Add Proton 4.11 #292

Closed
Lucki wants to merge 1 commit into from
Closed

Add Proton 4.11 #292

Lucki wants to merge 1 commit into from

Conversation

@Lucki
Copy link
Contributor

@Lucki Lucki commented Jul 30, 2019 •
edited
Loading

Haven't tested these changes yet, will do tomorrow.
There's also a new environment variable which may be interesting, don't know if it's worth adding to the settings window as it should be included into DXVK later anyway:

Proton now ships with D9VK v0.13f. D9VK is an experimental Vulkan-based Direct3D 9 renderer. It must be enabled by the user with the PROTON_USE_D9VK user setting.

@Lucki
Copy link
Contributor Author

Lucki commented Jul 31, 2019

It throws an error at the first start but works every time after that:
(tested in the dev branch)

wine: configuration in '/mnt/gamehub/gamehub/other/proton game/_gamehub/compat/proton_latest/pfx' has been updated.
Proton: Upgrading prefix from 3.16-1 to 4.11-1 (/mnt/gamehub/gamehub/other/proton game/_gamehub/compat/proton_latest)
Traceback (most recent call last):
  File "/mnt/steam/windows/steamapps/common/Proton 4.11/proton", line 468, in <module>
    win_vr_config = subprocess.check_output([wine_path, "winepath", "-w", vr_config], env=env, stderr=lfile).decode("utf-8")
  File "/usr/lib/python3.7/subprocess.py", line 395, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.7/subprocess.py", line 487, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/mnt/steam/windows/steamapps/common/Proton 4.11/dist/bin//wine', 'winepath', '-w', '/home/lucki/.local/share/Steam/config']' returned non-zero exit status 1.

tkashkin added a commit that referenced this pull request Jul 31, 2019
@tkashkin
Parse appinfo.vdf to find Proton versions (#292, #101)
788bb28
@tkashkin
Copy link
Owner

tkashkin commented Jul 31, 2019

Now GameHub will parse appinfo.vdf and find all available Proton versions.

Detected Proton versions are shown in settings:
image

@tkashkin tkashkin closed this Jul 31, 2019
@Lucki Lucki deleted the patch-1 branch July 31, 2019 11:12
@Lucki
Copy link
Contributor Author

Lucki commented Jul 31, 2019

Great! With d9vk built in it's now much more easy to play and test around.

@Lucki
Copy link
Contributor Author

Lucki commented Aug 2, 2019

I finally came around to try again but sadly I get a segmentation fault:

$ gamehub --debug                
[DEBUG]  [Database.migrate] Latest db version: 8, current: 8
[WARN]   [GLib-GObject] invalid cast from 'GameHubUtilsBinaryVDFIntNode' to 'GameHubUtilsBinaryVDFStringNode'
[1]    11348 segmentation fault (core dumped)  gamehub --debug

$ gamehub -v
- GameHub
    Version: 0.14.2-97b2775-makepkg
    Branch:  makepkg
    Commit:  97b277559b6e39ccc8db3dd27d48f5e434e55d35
- Environment
    Distro:  Arch Linux
    DE:      GNOME
    GTK:     3.24.10

@tkashkin
Copy link
Owner

tkashkin commented Aug 2, 2019

@Lucki some field in appinfo.vdf is int instead of string. Can you run GameHub with --gdb option?

@Lucki
Copy link
Contributor Author

Lucki commented Aug 2, 2019 •
edited
Loading

$ gamehub --gdb 
[INFO]   Restarting with GDB
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[DEBUG]  [Database.migrate] Latest db version: 8, current: 8
[Detaching after fork from child process 24140]
[Detaching after fork from child process 24141]
[WARN]   [GLib-GObject] invalid cast from 'GameHubUtilsBinaryVDFIntNode' to 'GameHubUtilsBinaryVDFStringNode'

Thread 1 "gamehub" received signal SIGSEGV, Segmentation fault.
0x00007ffff3b1a1ea in __strlen_sse2 () from /usr/lib/libc.so.6

Thread 4 (Thread 0x7fffe7833700 (LWP 24139)):
#0  0x00007ffff3b70667 in poll () at /usr/lib/libc.so.6
#1  0x00007ffff7c08a80 in  () at /usr/lib/libglib-2.0.so.0
#2  0x00007ffff7c08b51 in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0
#3  0x00007fffe7f7bbde in  () at /usr/lib/gio/modules/libdconfsettings.so
#4  0x00007ffff7be5a31 in  () at /usr/lib/libglib-2.0.so.0
#5  0x00007ffff305e57f in start_thread () at /usr/lib/libpthread.so.0
#6  0x00007ffff3b7b0e3 in clone () at /usr/lib/libc.so.6

Thread 3 (Thread 0x7fffec990700 (LWP 24138)):
#0  0x00007ffff3b70667 in poll () at /usr/lib/libc.so.6
#1  0x00007ffff7c08a80 in  () at /usr/lib/libglib-2.0.so.0
#2  0x00007ffff7c09a63 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#3  0x00007ffff7a22a38 in  () at /usr/lib/libgio-2.0.so.0
#4  0x00007ffff7be5a31 in  () at /usr/lib/libglib-2.0.so.0
#5  0x00007ffff305e57f in start_thread () at /usr/lib/libpthread.so.0
#6  0x00007ffff3b7b0e3 in clone () at /usr/lib/libc.so.6

Thread 2 (Thread 0x7fffed191700 (LWP 24137)):
#0  0x00007ffff3b70667 in poll () at /usr/lib/libc.so.6
#1  0x00007ffff7c08a80 in  () at /usr/lib/libglib-2.0.so.0
#2  0x00007ffff7c08b51 in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0
#3  0x00007ffff7c08ba2 in  () at /usr/lib/libglib-2.0.so.0
#4  0x00007ffff7be5a31 in  () at /usr/lib/libglib-2.0.so.0
#5  0x00007ffff305e57f in start_thread () at /usr/lib/libpthread.so.0
#6  0x00007ffff3b7b0e3 in clone () at /usr/lib/libc.so.6

Thread 1 (Thread 0x7fffed59da00 (LWP 24129)):
#0  0x00007ffff3b1a1ea in __strlen_sse2 () at /usr/lib/libc.so.6
#1  0x00007ffff7bde865 in g_strdup () at /usr/lib/libglib-2.0.so.0
#2  0x00005555555f6f0f in game_hub_data_compat_proton_find_proton_versions () at ../src/data/compat/Proton.vala:274
#3  0x000055555556ab3c in game_hub_application_init (self=0x5555557c51d0) at ../src/app.vala:151
#4  0x000055555556dc8a in game_hub_application_real_command_line (base=0x5555557c51d0, cmd=0x555555abd3a0) at ../src/app.vala:371
#5  0x00007ffff2c346d0 in ffi_call_unix64 () at /usr/lib/libffi.so.6
#6  0x00007ffff2c340a0 in ffi_call () at /usr/lib/libffi.so.6
#7  0x00007ffff7cfbf18 in g_cclosure_marshal_generic_va () at /usr/lib/libgobject-2.0.so.0
#8  0x00007ffff7ce3a5a in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#9  0x00007ffff7ce4700 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#10 0x00007ffff7a62d67 in  () at /usr/lib/libgio-2.0.so.0
#11 0x00007ffff7a659e2 in  () at /usr/lib/libgio-2.0.so.0
#12 0x000055555556d827 in game_hub_application_real_local_command_line (base=0x5555557c51d0, arguments=0x7fffffffd208, exit_status=0x7fffffffd204) at ../src/app.vala:345
#13 0x00007ffff7a65536 in g_application_run () at /usr/lib/libgio-2.0.so.0
#14 0x000055555556bb41 in game_hub_application_main (args=0x7fffffffd3b8, args_length1=2) at ../src/app.vala:240
#15 0x000055555556bb9a in main (argc=2, argv=0x7fffffffd3b8) at ../src/app.vala:224

tkashkin added a commit that referenced this pull request Aug 2, 2019
@tkashkin
Add type checks in Proton.find_proton_versions (#292, #101)
9b022f2
@tkashkin
Copy link
Owner

tkashkin commented Aug 2, 2019

@Lucki does it work in 9b022f2?

@Lucki
Copy link
Contributor Author

Lucki commented Aug 2, 2019

Yes, works now.

hagabaka pushed a commit to hagabaka/GameHub that referenced this pull request Aug 23, 2019
@tkashkin @hagabaka
Parse appinfo.vdf to find Proton versions (tkashkin#292, tkashkin#101)
34b3c90
hagabaka pushed a commit to hagabaka/GameHub that referenced this pull request Aug 23, 2019
@tkashkin @hagabaka
Add type checks in Proton.find_proton_versions (tkashkin#292, tkash…
bcfe0ee 
…kin#101)
Lucki pushed a commit to Lucki/GameHub that referenced this pull request Oct 30, 2021
@tkashkin
Parse appinfo.vdf to find Proton versions (tkashkin#292, tkashkin#101)
4b89c95 
Former-commit-id: 788bb28
Lucki pushed a commit to Lucki/GameHub that referenced this pull request Oct 30, 2021
@tkashkin
Add type checks in Proton.find_proton_versions (tkashkin#292, tkash…
d15da78 
…kin#101)

Former-commit-id: 9b022f2
Lucki pushed a commit to Lucki/GameHub that referenced this pull request Oct 30, 2021
@tkashkin @hagabaka
Parse appinfo.vdf to find Proton versions (tkashkin#292, tkashkin#101)
0aa21bc 
Former-commit-id: 34b3c90
Lucki pushed a commit to Lucki/GameHub that referenced this pull request Oct 30, 2021
@tkashkin @hagabaka
Add type checks in Proton.find_proton_versions (tkashkin#292, tkash…
bd9cc11 
…kin#101)

Former-commit-id: bcfe0ee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lucki @tkashkin