Repository navigation
GitHub Actions Workflows: remove Personal Access Token usage - #2387
jayaddison wants to merge 2 commits into
Conversation
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| fetch-depth: 0 # otherwise, you will fail to push refs to dest repo | ||
| persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal token |
There was a problem hiding this comment.
I'm taking a second look at this pull request, and I don't have a good reason why I removed the persist-credentials: false line. If we can keep it in place, then I think we should do that (minimisation of credentials and their exposure).
…eckout Partially reverts commit cffde71.
|
NB: I have tested that this GitHub Actions workflow job is able to commit codestyle-lint-fixup changes after removal of the Personal Access Token, and did that by using a pull request I opened including the commits from this branch on a fork of this repository at: https://github.com/jayaddison/eslint-changed-files/pull/1 |
|
@jackton1 ping? |
|
@jackton1 repinging - please could the personal access token usage here also be removed? |
|
@jackton1 ping? the |
|
@jackton1 hello - there's a GitHub PAT token configured in this repository - please could you take a look? |
|
I'm going to guess that for some reason my notifications didn't get through - maybe a notification configuration issue -- or alternatively that my initial PR as-opened at commit cffde71 seemed wrong/flawed and was, initially, untested. I'm going to close this and delete my branch since it doesn't seem likely to be accepted in the nearish future. The contents of this branch can, however, be retrieved from GitHub, and I'd be happy for anyone else to re-offer the same fix using these commits, which I believe consists of adding To do that with this repository configured as the $ git fetch upstream pull/2387/head:your-preferred-branch-name-here |
Refs:
GITHUB_TOKENinstead of personal access tokens where possible: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#keeping-your-personal-access-tokens-securead-m/github-push-actionaction: https://github.com/step-security/secure-repo/blob/bbbbe1ee6be6264c43271e2bc4376148bf6942f6/knowledge-base/actions/ad-m/github-push-action/action-security.ymlcc @jackton1