Add support for "lts" alias, closes #313 by stefanmaric · Pull Request #322 · tj/n

stefanmaric · 2015-11-05T03:05:43Z

--lts will display latest LTS version
lts will install latest LTS version

Node LTS releases use "a naming convention based on the Periodic
Table of Elements [...] in alphabetical order", as announced here:
https://nodejs.org/en/blog/release/v4.2.0/

LTS versions have their own folder in nodejs' dist folder, e.g.:
https://nodejs.org/dist/latest-argon/

To retrieve latest LTS' latest version, we search for and fetch
that folder. We get the semver number from the first file that
holds it. Then we can fetch the tarball.

--lts will display latest LTS version lts will install latest LTS version Node LTS releases use "a naming convention based on the Periodic Table of Elements [...] in alphabetical order", as announced here: https://nodejs.org/en/blog/release/v4.2.0/ LTS versions have their own folder in nodejs' dist folder, e.g.: https://nodejs.org/dist/latest-argon/ To retrieve latest LTS' latest version, we search for and fetch that folder. We get the semver number from the first file that holds it. Then we can fetch the trallbar.

jwhitmarsh · 2015-11-10T13:06:02Z

This is cool - can it be merged and released?

fluffywaffles · 2015-11-13T17:42:28Z

👍
I'd be eager to see this merged; I literally searched for "n lts" and ended up here!

qw3rtman · 2015-11-14T22:53:46Z

I think it'd be nice to have a n lts <version> as well. I haven't taken a look at the URL schema for these LTS releases, so I'm not sure how difficult it would be to implement this. Thoughts?

For now, I think this is a great addition. //cc @tedgaydos @benatkin @tjwebb @troy0820

tejasmanohar · 2015-11-15T18:54:44Z

+1

@qw3rtman Example usage of n lts <version? Generally, only 1 version is supported as "LTS" by an organization at a given time, right (I may be wrong)?

tejasmanohar · 2015-11-15T19:06:04Z

Also, I think we should remove stable in favor of the existence of both lts and latest since stable is a bit ambiguous now... Thoughts, @qw3rtman / @stefanmaric? Sent a (sub-)PR to the fork / the branch of this PR- https://github.com/stefanmaric/n/pull/2

ghost · 2015-11-15T19:38:27Z

I will want to keep stable in place for backward compatibility. It will just become an alias to lts. I do not think there will be any ambiguity.

tejasmanohar · 2015-11-15T19:40:27Z

fair enough

stefanmaric · 2015-11-15T21:50:11Z

There can be more than 1 LTS version in a given point in time, based on this: https://github.com/nodejs/LTS/blob/master/README.md

But I would say it is unnecessary for now. When I think in n lts I want to get the latest version of nodejs with Long Term Support.

Anyway, in current n codebase, I can easily make --lts display available LTS versions and lts <version-name> install a specific one. A problem is that it requires few more HTTP calls to get it.

Nodejs' dist folder has index.json and index.tab files, which I think creationix/nvm uses. Those files, each, contain a lot of metadata, including which versions are LTS. Using any of those would skip HTTP calls but it would also mean a rewrite of n. (and I actually prefer current simplicity of n)

About @tejasmanohar pull request: I agree with removing the stable alias because it now means latest. Probably the nodejs team will be releasing canary builds in the feature and we could add canary and --canaty to n. But removing stable alias breaks backwards compatibility so, I would send this PR for a MINOR release and leave the removal of stable for a future MAJOR, following semver.org

PD: I wrote this message some hours ago but forgot to send it.

tejasmanohar · 2015-11-15T22:02:04Z

About @tejasmanohar pull request: I agree with removing the stable alias because it now means latest. Probably the nodejs will be releasing canary builds in the feature and we could add canary and --canaty to n. But removing stable alias breaks backwards compatibility so, I would send this PR for a MINOR release and leave the removal of stable for a future MAJOR, following semver.org

Right, agreed.

ghost · 2015-11-16T01:15:55Z

index.json may not be up to date. a real early version of n used it and it did not work out. That is why it went to scanning the dist site for version numbers. I would not go to far into LTS with specific release names. All LTS version will still follow the semver system. I am going to leave LTS as the newest LTS. If you want an "older" LTS, you can still use n <version> like n 4.2 to get Argon.

stefanmaric · 2015-11-16T14:57:32Z

So we are good to go with this PR, right? (I kinda need this in npm for prod stuff. 😄 )

jwhitmarsh · 2015-11-30T13:54:56Z

👍 would really like to see this merged :)

tejasmanohar · 2015-11-30T15:42:56Z

@stefanmaric n, not npm, right? :)

stefanmaric · 2015-12-01T22:57:19Z

I meant the npm registry @tejasmanohar, so I can distribute some scripts to my peers. 😄

Already a month since I submitted the PR, won't merge? 😢

ffaubert · 2015-12-05T15:24:01Z

Would really love to have this functionality soon.

stefanmaric · 2015-12-17T16:57:30Z

cc: @maxrimue

maxrimue · 2015-12-17T17:15:16Z

@stefanmaric I'm sorry, but I'm not a collaborator any more, which means that I do not have permissions to merge this

stefanmaric · 2015-12-17T17:35:11Z

I'm sorry, but I'm not a collaborator any more, which means that I do not have permissions to merge this

What a pity. :c

Who's in charge now? There's a good amount of users willing to use this feature (including myself 😄 ).

cc: @tj

qw3rtman · 2015-12-17T18:37:24Z

I'm willing to merge. @tedgaydos is this good with you?

ghost · 2015-12-18T00:12:09Z

You can merge it if you want. It looks fine. I will look to get this published to npm this weekend. I was away on a long project that is winding down.

tjwebb · 2015-12-18T01:04:46Z

+1

Add Support for LTS Alias

stefanmaric added 2 commits November 4, 2015 22:20

Add lts alias reference to README

bfd834f

stefanmaric mentioned this pull request Nov 6, 2015

Node has released a new type of release #313

Closed

qw3rtman added the enhancement label Nov 14, 2015

qw3rtman added a commit that referenced this pull request Dec 18, 2015

Merge pull request #322 from stefanmaric/feature/lts

bf6e303

Add Support for LTS Alias

qw3rtman merged commit bf6e303 into tj:master Dec 18, 2015

stefanmaric mentioned this pull request Jan 14, 2016

Allow lts alias for automated installation mklement0/n-install#4

Merged

shadowspawn mentioned this pull request Nov 5, 2018

Improved timeliness of LTS changes across major versions #535

Closed

Uh oh!

Conversation

stefanmaric commented Nov 5, 2015

Uh oh!

jwhitmarsh commented Nov 10, 2015

Uh oh!

fluffywaffles commented Nov 13, 2015

Uh oh!

qw3rtman commented Nov 14, 2015

Uh oh!

tejasmanohar commented Nov 15, 2015

Uh oh!

tejasmanohar commented Nov 15, 2015

Uh oh!

ghost commented Nov 15, 2015

Uh oh!

tejasmanohar commented Nov 15, 2015

Uh oh!

stefanmaric commented Nov 15, 2015

Uh oh!

tejasmanohar commented Nov 15, 2015

Uh oh!

ghost commented Nov 16, 2015

Uh oh!

stefanmaric commented Nov 16, 2015

Uh oh!

jwhitmarsh commented Nov 30, 2015

Uh oh!

tejasmanohar commented Nov 30, 2015

Uh oh!

stefanmaric commented Dec 1, 2015

Uh oh!

ffaubert commented Dec 5, 2015

Uh oh!

stefanmaric commented Dec 17, 2015

Uh oh!

maxrimue commented Dec 17, 2015

Uh oh!

stefanmaric commented Dec 17, 2015

Uh oh!

qw3rtman commented Dec 17, 2015

Uh oh!

ghost commented Dec 18, 2015

Uh oh!

tjwebb commented Dec 18, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants