feat: implement git-browse-ci#959
Merged
spacewander merged 5 commits intotj:masterfrom Apr 13, 2022
Merged
Conversation
spacewander
reviewed
Mar 20, 2022
spacewander
reviewed
Mar 21, 2022
| @@ -1,5 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -e -o pipefail | |||
Collaborator
There was a problem hiding this comment.
I get 128 exit code when no upstream is given after this modification...
Contributor
Author
There was a problem hiding this comment.
It seems to be the combination of set -e and git rev-parse --abbrev-ref HEAD 2&> /dev/null (specifically the 2&> /dev/null).
Changing it to the shorthand version &> /dev/null or the longhand version >/dev/null 2>&1 fixes it for me.
spacewander
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal and an implementation to open repo's CI page (e.g. GitHub Actions, GitLab CI, Bitbucket Pipelines) in default browser.
Feedback is welcome, even if feedback is "thanks, but no thanks".