feat(git-bulk): add new option to not follow hidden directories#1195
Merged
spacewander merged 7 commits intotj:mainfrom Mar 5, 2025
Merged
feat(git-bulk): add new option to not follow hidden directories#1195spacewander merged 7 commits intotj:mainfrom
spacewander merged 7 commits intotj:mainfrom
Conversation
hyperupcall
requested changes
Feb 26, 2025
Collaborator
hyperupcall
left a comment
hyperupcall
left a comment
There was a problem hiding this comment.
Thanks! Feature is good. Had a question about implementation
Remove unnecessary subshell Co-authored-by: Edwin Kofler <[email protected]>
With the Bash' regexp matching operator `=~`, we need to use the Bash conditional expression evaluation command `[[ ]]`.
pierreay
force-pushed
the
feat/git-bulk-no-follow-hidden
branch
from
cc083e9 to
8121c97
Compare
Contributor
Author
|
Fixed the implementation as requested and rebased on |
spacewander
approved these changes
Mar 4, 2025
spacewander
reviewed
Mar 4, 2025
Collaborator
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
@pierreay
Do we need to update the completion script?
Contributor
Author
@spacewander Actually, I did it on a local branch, but not merged into the branch of the PR...sorry! And I forgot the completion in the same way for the already merged #1194... So I cherry-picked the right commit for the two PRs (this one and the mentioned one) at the same time. ;) |
spacewander
approved these changes
Mar 5, 2025
Collaborator
|
@pierreay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new option
--no-follow-hiddenforgit-bulkto not traverse hidden directories (containing a dot at the beginning) under the workspace directories when searching for git repositories. This PR does not change the default behavior, it only adds the option for the user.Note that on the implementation, I did not changed the way
findis searching for directories. Instead, I checked using a regex before performing the operation if we are under a hidden directory. This was the easiest way I found.