fix(github-actions): changed files output for editorcondig-checker#1180
fix(github-actions): changed files output for editorcondig-checker#1180spacewander merged 2 commits intotj:mainfrom
Conversation
Seems that ci.yml includes a dead dependency action just to get list of changed files for the PR / push. This seems weird as the repo is all about git. Propose removing this extra dep with straightforward implemenation. Also: github runners do have `jq` preinstalled.
oikarinen
force-pushed
the
changed-files
branch
2 times, most recently
from
2ca553e to
9d36a8f
Compare
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
| run: | | ||
| { | ||
| echo "added_modified<<EOF" | ||
| git diff --name-only "${BASE_SHA:-$BEFORE_SHA}...${HEAD_SHA:-GITHUB_REF}" |
There was a problem hiding this comment.
Would you print the diff result to the output so that we can check it if the CI doesn't work well?
There was a problem hiding this comment.
Hey, this can be verified by running the github actions in debug mode, then github will log the contents of the env variable. But for sure it would be easier by just printing that in the step. I will amend!
|
@oikarinen |
|
@oikarinen |
Yeah that's it! i did test the pull_request and then called it good and the push path was not covered 🥹 |
|
@spacewander here's the missing |
2 participants
Seems that ci.yml includes a dead dependency action just to get list of changed files for the PR / push. This seems weird as the repo is all about git. Propose removing this extra dep with straightforward implementation that supports force push for the PR branches.
Also:
jqpreinstalled, so that was redundant and now no longer needed.