Support GITHUB_TOKEN var for git-fork and git-pull-request#1177
Merged
hyperupcall merged 3 commits intotj:mainfrom Nov 16, 2024
Merged
Support GITHUB_TOKEN var for git-fork and git-pull-request#1177hyperupcall merged 3 commits intotj:mainfrom
GITHUB_TOKEN var for git-fork and git-pull-request#1177hyperupcall merged 3 commits intotj:mainfrom
Conversation
spacewander
reviewed
Nov 14, 2024
Contributor
Author
|
Thanks for the review ! |
hyperupcall
requested changes
Nov 14, 2024
Contributor
Author
|
@hyperupcall what would you think about dropping that switch, and using only one ? |
Collaborator
|
@nim65s That's perfect! |
Co-authored-by: 罗泽轩 <[email protected]>
hyperupcall
approved these changes
Nov 14, 2024
spacewander
reviewed
Nov 15, 2024
Collaborator
|
Great, thanks! |
hyperupcall
changed the title
GITHUB_TOKEN var for git-fork and git-pull-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
git-fork&git-pull-requestcurrently require to set github token in git config global file.I would like to keep this file versionned and public on github, so I would prefer not having to put secrets inside.
A common solution to this issue is to pass that token through the
GITHUB_TOKENenvironment variable instead.Here is a simple commit implementing and documenting that.
ref. #839