Enhance git-repl#1160
Merged
hyperupcall merged 18 commits intotj:mainfrom Sep 23, 2024
wyattscarpenter:patch-2
Merged
Conversation
if the changing left margin is a problem, a tab character could perhaps be added
hyperupcall
requested changes
Sep 16, 2024
Collaborator
There was a problem hiding this comment.
Thanks! These are good changes - everything mostly LGTM - I just had a single nitpick. I'm also thinking that adding x as a way to exit the repl might be an option to much/excessive. Not sure what @spacewander thinks about that
Contributor
Author
|
Oddly enough: I only added x because I wanted to add q and assumed that people who prefer the term exit over the term quit would object to my blatant favoritism if I didn't add x as well! I'm quite happy to remove it, myself |
spacewander
reviewed
Sep 17, 2024
Both ways seem to work, so I don't oppose the change.
spacewander
reviewed
Sep 22, 2024
Collaborator
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
Please update the doc after fixing the typo
spacewander
approved these changes
Sep 23, 2024
hyperupcall
approved these changes
Sep 23, 2024
Collaborator
hyperupcall
left a comment
hyperupcall
left a comment
There was a problem hiding this comment.
Thanks! The new changes are much improved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes 3 improvements to git-repl:
It displays the exit code of the previous command
The message at the beginning now tells you how to quit. q
and xhave been added as commands that quitIf git-repl is given arguments, it will be evaluate them as the first command.
Closes #1159