fix: git-summary commit count#1147
Merged
spacewander merged 2 commits intotj:mainfrom Jun 18, 2024
Merged
Conversation
spacewander
reviewed
Jun 17, 2024
| commit_count() { | ||
| # shellcheck disable=SC2086 | ||
| git log $MERGES_ARG --oneline "$commit" | wc -l | tr -d ' ' | ||
| git rev-list --count "$commit" |
Collaborator
There was a problem hiding this comment.
We pass --no-merges via $MERGES_ARG. How could we handle this with rev-list?
Contributor
Author
There was a problem hiding this comment.
I missed it, updated.
spacewander
approved these changes
Jun 18, 2024
Collaborator
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user has set log.showSignature = ture in gitconfig file, then the
commitsfield in the git-summary result is wrong. Replacegit logwithgit rev-listto avoid the problem,git rev-listisn't affected by log.* config parameters, which is also the same asgit-countcommand.The result of
git log --oneline HEADis as follows, then| wc -l | tr -d ' 'get wrong count.