Skip to content

Add the current branch git summary#1034

Merged
spacewander merged 1 commit intotj:masterfrom
guenhter:add-current-branch-to-summary
Feb 27, 2023
Merged

Add the current branch git summary#1034
spacewander merged 1 commit intotj:masterfrom
guenhter:add-current-branch-to-summary

Conversation

@guenhter
Copy link
Copy Markdown
Contributor

Simply adds the current branch name to the summary output.

Comment thread Commands.md Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the non-output-style version too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. This slipped through. It is not updated. I double checked all locations and the branch is not contained everywhere.

Comment thread bin/git-summary Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like we need to escape the branch name, as it can contain /

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean by "escape" to just put it withing double quotes?

On the other hand, is it a problem if the branch name contains a /, because it is anyway just some output...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we escape the /, can awk or column handle it correctly?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if you want to awk this line, you always can use / (space before and after) to distinguish it from slashes in a text

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can mention the space before and after in the doc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I mentioned the separator for the tabular and the oneline option in the documentation and also that they are surrounded by spaces.

@spacewander
Copy link
Copy Markdown
Collaborator

Would you solve the conflict? Thanks!

@guenhter
Copy link
Copy Markdown
Contributor Author

Done.

Copy link
Copy Markdown
Collaborator

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guenhter
Copy link
Copy Markdown
Contributor Author

Sorry for committing .idea again. It's gone now.

@spacewander spacewander merged commit d5eaa18 into tj:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants