Skip to content

chore: Improve quoting and builtin usage#1015

Merged
spacewander merged 1 commit intotj:masterfrom
hyperupcall:bash-fixes
Jan 4, 2023
Merged

chore: Improve quoting and builtin usage#1015
spacewander merged 1 commit intotj:masterfrom
hyperupcall:bash-fixes

Conversation

@hyperupcall
Copy link
Copy Markdown
Collaborator

@hyperupcall hyperupcall commented Jan 2, 2023

  • Uses $() instead of ``
  • Qutoes variables like paths (branches are skipped over for now because they are forbidden to include whitespace)
  • Use grep -E instead of deprecated egrep

@spacewander spacewander merged commit 35100b4 into tj:master Jan 4, 2023
@hyperupcall hyperupcall deleted the bash-fixes branch January 4, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants