Skip to content

fix base branch in the pull-request command#1003

Merged
spacewander merged 1 commit intotj:masterfrom
zhiyanfoo:zhiyan/fix-default-base-pull-request
Nov 12, 2022
Merged

fix base branch in the pull-request command#1003
spacewander merged 1 commit intotj:masterfrom
zhiyanfoo:zhiyan/fix-default-base-pull-request

Conversation

@zhiyanfoo
Copy link
Copy Markdown
Contributor

@zhiyanfoo zhiyanfoo commented Nov 11, 2022

We don't actually use the default branch that we print in the prompt (see line 67)

printf "  base [%s]: " "$(git_extra_default_branch)" && read -r base

@zhiyanfoo zhiyanfoo changed the title fix base branch fix base branch in the pull-request command Nov 11, 2022
@spacewander spacewander merged commit 193a6dd into tj:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants