Feature/argument arg explicit#1567
Merged
shadowspawn merged 4 commits intotj:developfrom Jul 12, 2021
Merged
Conversation
Collaborator
Author
|
Released in Commander v8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Fill out the Argument methods to allow explicit configuration of required/optional with a fluent method. This is an alternative to implicit syntax using brackets in name string.
Related: #1359 (comment)
Problem
The syntax for required (
<arg>) and optional ([arg]) command-arguments needs to be learned. (However, this is consistent with the syntax shown in the help so is actually useful to learn!)Solution
Offer an explicit method to set whether option is required or optional.
The method naming is intended to be the same for adding matching methods to Option in future.
ChangeLog
.argRequired()and.argOptional().