Add tips about showing help instead of just missing arguments error#1547
Merged
shadowspawn merged 2 commits intotj:release/8.xfrom Jun 13, 2021
Merged
Conversation
abetomo
reviewed
Jun 13, 2021
| If you have a simple program without an action handler, you will now get an error if | ||
| there are missing command-arguments. | ||
|
|
||
| ``` |
Collaborator
There was a problem hiding this comment.
I think an indent width of 2 is better.
Because other code examples are 2.
It would be nice to have a highlight setting as well. ```js
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The behaviour is changing in Commander 8 for very simple programs which previously could decide after parsing what to do (if anything) about missing command-arguments.
Solution
Add a couple of simple approaches to Migration Tips in CHANGELOG.
I am not sure whether this come up much, but I'm thinking of the fairly casual users of Commander.