Support argument processing without action handler#1529
Merged
shadowspawn merged 4 commits intotj:release/8.xfrom Jun 2, 2021
Merged
Support argument processing without action handler#1529shadowspawn merged 4 commits intotj:release/8.xfrom
shadowspawn merged 4 commits intotj:release/8.xfrom
Conversation
Collaborator
Author
|
Thanks @abetomo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The new processing of arguments is also useful in a single command program without an action handler, but
argument defaults and custom processing and choices were only being applied if there was an action handler.
Prompted by realising
.choices()would not work without action handler.Solution
Refactor and process command-arguments whether or not action handler.
When adding the functionality in #1508 I had decided that I preferred not to modify
this.argswith processed results.Save processed arguments as
this.processedArgsso accessible for simple program without action handler, and from the new hook support too.This PR includes some minor other improvements:
Changelog
Commandproperty.arginitialised to empty array (was previously undefined)