Skip to content

Set up an CI/CD pipeline to verify build integrity#1

Closed
tishun wants to merge 7 commits intomainfrom
topic/tishun/cicdv1
Closed

Set up an CI/CD pipeline to verify build integrity#1
tishun wants to merge 7 commits intomainfrom
topic/tishun/cicdv1

Conversation

@tishun
Copy link
Copy Markdown
Owner

@tishun tishun commented Mar 8, 2024

Include a Github action to start the CI/CD pipeline
Fixed a dependency that is failing for linux based builds

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tishun tishun closed this Mar 26, 2024
@tishun tishun deleted the topic/tishun/cicdv1 branch March 26, 2024 13:58
tishun added a commit that referenced this pull request Feb 3, 2025
tishun added a commit that referenced this pull request Feb 3, 2025
* Introducing the FT.CREATE command

* Formatter issues

* Polishing #1
tishun pushed a commit that referenced this pull request Oct 22, 2025
…redis#3461)

* feat(CAE-1130): Add comprehensive connection testing for Redis Enterprise maintenance events

- Add ConnectionTesting class with 9 test scenarios for maintenance handoff behavior
- Test old connection graceful shutdown during MOVING operations
- Validate traffic resumption with autoconnect after handoff
- Verify maintenance notifications only work with RESP3 protocol
- Test new connection establishment during migration and bind phases
- Add memory leak validation for multiple concurrent connections
- Include TLS support testing for maintenance events
- Replace .supportMaintenanceEvents(true) with MaintenanceEventsOptions.enabled()
- Add comprehensive monitoring and validation of connection lifecycle

Tests cover CAE-1130 requirements for Redis Enterprise maintenance event handling
including connection draining, autoconnect behavior, and notification delivery.

* Add comprehensive maintenance events tests for CLIENT MAINT_NOTIFICATIONS

- connectionHandshakeIncludesEnablingNotificationsTest: Verifies all 5 notification types (MOVING, MIGRATING, MIGRATED, FAILING_OVER, FAILED_OVER) are received when maintenance events are enabled
- disabledDontReceiveNotificationsTest: Verifies no notifications received when maintenance events are disabled
- clientHandshakeWithEndpointTypeTest: Tests CLIENT MAINT_NOTIFICATIONS with 'none' endpoint type (nil IP scenario)
- clientMaintenanceNotificationInfoTest: Verifies CLIENT MAINT_NOTIFICATIONS configuration with moving-endpoint-type

Based on CLIENT MAINT_NOTIFICATIONS implementation from commit bd408cf

* Update Redis Enterprise maintenance event notification protocol

- Update push notification patterns to include sequence numbers (4-element format)
- Fix MOVING notification parsing to handle new address format with sequence and time
- Update MIGRATING, MIGRATED, FAILING_OVER, and FAILED_OVER patterns with sequence numbers
- Improve FaultInjectionClient status handling: change from 'pending' to 'running' checks
- Enhance JSON response parsing with better output field handling and debugging
- Remove deprecated maintenance sequence functionality and associated unit test
- Add test phase isolation to prevent cleanup notification interference
- Extend monitoring timeout from 2 to 5 minutes for longer maintenance operations
- Add @AfterEach cleanup to restore cluster state between tests
- Remove hardcoded optimal node selection logic in RedisEnterpriseConfig

This aligns with the updated Redis Enterprise maintenance events specification
and improves test reliability by handling the new notification protocol format.

* Fix moving tests for timeout de-relaxation after moving

* fix notification capture logic and several tests.

* fix up resp2 test, and add proper test for None, will rebase to master

* Fix None test

* Fix several tests related to handling. 5 tests left to fix up.

* fix up new connection test and connection leak tests

* fix up traffic test and remove un-needed code.

* fix more tests, remove more un-needed code

* revert log changes

* revert the re-throw change, to be discussed

* remove resp3 test after offline discussion

* change endpoint name

* temporarely reduce number of tests

* add more tests

* reduce test execution time by 50%

* remove hardcoded target config and enable working with 6 nodes and multiple dbs

* fix up relaxedtimeoutconfig to use newest functions and add connection handoff test

* add 1 more handoff test, add more logging, fix some issues that were raised during review

* fix some bugs and remove the un-needed clean-up of testing, to speed up tests by 50%

* Merge pull request #1 from kiryazovi-redis/CI-fix-functional-handoff-and-connection-testing-of-maint-events-2

Ci fix functional handoff and connection testing of maint events 2

* optimise relaxed timeoutest, fix compilation issues after renaming done by Ivo

* remove MaintenanceNotificationTest, as all functionality is covered now, also implement more fixes and improvements

* renamed memoryleak infra, refactored several tests, implemented more fixes from review, started removin comments

* remove any useless sleeps, refactor several tests again to be more functionally correct, enable logging for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant