Conversation
benmccann
approved these changes
Aug 22, 2024
Contributor
benmccann
left a comment
There was a problem hiding this comment.
Looks good to me! It'd probably be good to add some docs
d1cc244 to
703c3ce
Compare
Member
Author
|
have updated to be a |
Introduces a new `throwOnError` option which will cause tinyexec to
throw any time a non-zero exit code is encountered.
If the exit code is `null`, we will not throw since it means something
went very wrong anyway (the process is still running and shouldn't be,
since we saw the `close` event by then).
If the exit code is greater than `0`, we will throw a
`NonZeroExitError` which has an `exitCode` property.
For example:
```ts
try {
await x('foo', [], {throwOnError: true});
} catch (err) {
if (err instanceof NonZeroExitCode) {
err.exitCode; // the exit code
err.result; // the tinyexec process
err.result.killed; // getters on tinyexec process
}
}
```
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
throwOnErroroption which will cause tinyexec tothrow any time a non-zero exit code is encountered.
If the exit code is
null, we will not throw since it means somethingwent very wrong anyway (the process is still running and shouldn't be,
since we saw the
closeevent by then).If the exit code is greater than
0, we will throw aNonZeroExitErrorwhich has anexitCodeproperty.For example:
cc @benmccann