[codex] fix numeric grounding in agent prompts#3678
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo lines are added to the ChangesNumeric Evidence Grounding Contract
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Problem
Solution
GROUNDING_BODYprompt contract instead of adding a separate post-processor.Submission Checklist
## Related— N/A: no matrix feature IDs affected.docs/RELEASE-MANUAL-SMOKE.md) — N/A: no release-cut manual smoke surface changed.Closes #NNNin the## Relatedsection.Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/numeric-tool-output-guardrails4512d962Validation Run
pnpm --filter openhuman-app format:checkpnpm typecheckcargo test --manifest-path Cargo.toml openhuman::agent::prompts::tests -- --nocapturecargo fmt --manifest-path Cargo.toml --all --check;cargo check --manifest-path Cargo.tomlcargo fmt --manifest-path app/src-tauri/Cargo.toml --all --checkandcargo check --manifest-path app/src-tauri/Cargo.tomlValidation Blocked
command:N/A after setup.error:N/A after setup. Local pre-push initially failed because app dependencies and vendored Tauri submodules were missing; resolved withpnpm installandgit submodule update --init --recursive.impact:Final push hooks passed. Local environment still warns that Node isv22.22.3while the repo requests>=24.0.0.Behavior Changes
Parity Contract
SystemPromptBuilder::buildand the narrow sub-agent renderer.Duplicate / Superseded PR Handling
#3603before publishing.Summary by CodeRabbit
Bug Fixes
Tests