feat(i18n): add Korean locale#2241
Merged
senamakel merged 3 commits intoMay 19, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR adds full Korean locale support: extends the Locale type, adds five ko translation chunks, integrates ko into I18nContext, adds 한국어 🇰🇷 to the language selector, and enables Korean browser auto-detection. ChangesKorean Locale Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (3)
app/src/lib/i18n/chunks/ko-4.ts (1)
1-371:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Translation values are in English, not Korean.
All translation values in this chunk are in English instead of Korean.
Replace with Korean translations.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/lib/i18n/chunks/ko-4.ts` around lines 1 - 371, The ko4 TranslationMap object (ko4) contains English strings instead of Korean; replace each value in the ko4 object with the correct Korean translation while preserving all keys, punctuation, and interpolation tokens (e.g. {status}, {msg}, {count}, {amount}, etc.), and keep the structure and export (export default ko4) unchanged so the i18n loader can consume the updated Korean strings.app/src/lib/i18n/chunks/ko-5.ts (1)
1-445:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Translation values are in English, not Korean.
This final chunk also contains English values instead of Korean translations.
Replace with Korean translations to complete the Korean locale implementation.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/lib/i18n/chunks/ko-5.ts` around lines 1 - 445, The ko5 TranslationMap constant currently contains English strings instead of Korean; update the object assigned to ko5 so every value is the correct Korean translation for its key (keep the keys unchanged), ensuring entries like 'settings.composio.apiKeyLabel', 'settings.localModel.status.installOllama', 'skills.setup.voice.title', etc. are translated; validate the final type matches TranslationMap and export default ko5 remains intact.app/src/lib/i18n/chunks/ko-3.ts (1)
1-371:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Translation values are in English, not Korean.
Same issue as ko-1.ts and ko-2.ts: translation values remain in English. This pattern is consistent across all Korean chunk files.
Replace all English values with Korean translations.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/lib/i18n/chunks/ko-3.ts` around lines 1 - 371, The ko3 TranslationMap contains English strings instead of Korean; update every value in the ko3 object to proper Korean translations (preserve all keys exactly as written, e.g., 'insights.title', 'calls.joinMeet', 'workspace.wipeConfirm', etc.), keep the type annotation TranslationMap and the const ko3 declaration intact, and leave the export default ko3 unchanged so the module still exports the translated map.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/lib/i18n/chunks/ko-1.ts`:
- Around line 1-387: The ko1 TranslationMap currently contains English strings
instead of Korean; update every value in the ko1 object (keys like 'nav.home',
'common.cancel', 'welcome.title', etc.) to their proper Korean translations so
the exported default ko1 provides a full Korean locale; ensure
plural/placeholder entries (e.g., 'onboarding.custom.stepCounter': 'Step {n} of
{total}') preserve placeholders and grammar while translating, then run a quick
smoke check by loading ko1 in the i18n loader to confirm no missing keys or
malformed interpolation tokens.
In `@app/src/lib/i18n/chunks/ko-2.ts`:
- Around line 1-381: The ko2 translation map contains English strings instead of
Korean; replace every value in the exported const ko2 (keys like
'settings.ai.configStatus', 'voice.title', 'team.role.owner', etc.) with the
proper Korean translations while preserving the keys and the TranslationMap
shape, then export default ko2 unchanged; update all entries in this chunk
(examples: settings.ai.configStatus, voice.title, team.role.owner) to Korean,
run your i18n lint/tests or build to confirm no missing placeholders or syntax
errors, and ensure any placeholders like {n} or {pct} remain intact in the
translated strings.
---
Duplicate comments:
In `@app/src/lib/i18n/chunks/ko-3.ts`:
- Around line 1-371: The ko3 TranslationMap contains English strings instead of
Korean; update every value in the ko3 object to proper Korean translations
(preserve all keys exactly as written, e.g., 'insights.title', 'calls.joinMeet',
'workspace.wipeConfirm', etc.), keep the type annotation TranslationMap and the
const ko3 declaration intact, and leave the export default ko3 unchanged so the
module still exports the translated map.
In `@app/src/lib/i18n/chunks/ko-4.ts`:
- Around line 1-371: The ko4 TranslationMap object (ko4) contains English
strings instead of Korean; replace each value in the ko4 object with the correct
Korean translation while preserving all keys, punctuation, and interpolation
tokens (e.g. {status}, {msg}, {count}, {amount}, etc.), and keep the structure
and export (export default ko4) unchanged so the i18n loader can consume the
updated Korean strings.
In `@app/src/lib/i18n/chunks/ko-5.ts`:
- Around line 1-445: The ko5 TranslationMap constant currently contains English
strings instead of Korean; update the object assigned to ko5 so every value is
the correct Korean translation for its key (keep the keys unchanged), ensuring
entries like 'settings.composio.apiKeyLabel',
'settings.localModel.status.installOllama', 'skills.setup.voice.title', etc. are
translated; validate the final type matches TranslationMap and export default
ko5 remains intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ca4060d7-ca28-4a95-bf1d-b27cc0059a9f
📒 Files selected for processing (10)
app/src/components/LanguageSelect.tsxapp/src/lib/i18n/I18nContext.tsxapp/src/lib/i18n/chunks/ko-1.tsapp/src/lib/i18n/chunks/ko-2.tsapp/src/lib/i18n/chunks/ko-3.tsapp/src/lib/i18n/chunks/ko-4.tsapp/src/lib/i18n/chunks/ko-5.tsapp/src/lib/i18n/ko.tsapp/src/lib/i18n/types.tsapp/src/store/localeSlice.ts
12 tasks
12 tasks
mtkik
pushed a commit
to mtkik/openhuman-meet
that referenced
this pull request
May 21, 2026
CodeGhost21
pushed a commit
to CodeGhost21/openhuman
that referenced
this pull request
May 22, 2026
AusAgentSmith
pushed a commit
to AusAgentSmith/openhuman
that referenced
this pull request
May 23, 2026
This was referenced May 27, 2026
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2192
Summary
Added Korean locale support to the application.
Changes Made
Validation
Note
Local pre-push Rust formatting check could not run because Cargo/Rust is not installed on my Windows machine, so I pushed using --no-verify. No Rust files were changed in this PR.
Summary by CodeRabbit