Add enough tls.ConnectionState and tls.CipherSuiteName() to compile fortio/log#4345
Add enough tls.ConnectionState and tls.CipherSuiteName() to compile fortio/log#4345deadprogram merged 2 commits intotinygo-org:devfrom
Conversation
src/crypto/tls/common.go
Outdated
| // TINYGO: empty; TLS connection offloaded to device | ||
| // TINYGO: empty; TLS connection offloaded to device [?] | ||
| // | ||
| // Minimum (empty) fields for fortio.org/log http logging to |
There was a problem hiding this comment.
What is the broader implication? net/http compatibility?
There was a problem hiding this comment.
well... if I ever get a super simple server working with tinygo, it'd have the logging I use elsewhere for servers... I haven't tried others but mine does need these fields even empty to compile
edit: the wip test is https://github.com/ldemailly/go-scratch/blob/main/tinyhttp/tinyhttp.go
There was a problem hiding this comment.
in short it's incremental progress - can we merge?
|
@deadprogram thanks for having merged the other, what about this one :) cheers |
|
(just rebased) |
|
Thanks for the addition @ldemailly and to @dgryski for review. Now merging. |
|
thx! ❤️ |
4 participants
Note that net/http is broken on macOS but this allows it to work on Linux (and waspi)
edit: linux also doesn't work #4346