Make sure InstallLocation path is formatted correctly

tinodin · tinodin · commit 2aa3fb3fb83f · 2026-03-03T12:06:30.000+01:00
diff --git a/Assets/Scripts/txintdelay.ps1 b/Assets/Scripts/txintdelay.ps1
diff --git a/Helpers/GPU/NvidiaHelper.cs b/Helpers/GPU/NvidiaHelper.cs
@@ -1,11 +1,11 @@
 ﻿using AutoOS.Views.Installer.Actions;
 using System.Diagnostics;
-using System.Net;
 using System.Net.Security;
 using System.Text.Json;
 using Windows.Win32.System.Power;
 using Windows.Win32;
-
+using System.Net.Http.Headers;
+using System.Security.Authentication;
 namespace AutoOS.Helpers.GPU
 {
     public static class NvidiaHelper
@@ -14,17 +14,17 @@ public static class NvidiaHelper
         {
             SslOptions = new SslClientAuthenticationOptions
             {
-                EnabledSslProtocols = System.Security.Authentication.SslProtocols.Tls12 | System.Security.Authentication.SslProtocols.Tls13
+                EnabledSslProtocols = SslProtocols.Tls12 | SslProtocols.Tls13
             }
         })
         {
             DefaultRequestHeaders =
-        {
-            UserAgent =
             {
-                new System.Net.Http.Headers.ProductInfoHeaderValue("AutoOS", ProcessInfoHelper.Version)
+                UserAgent =
+                {
+                    new ProductInfoHeaderValue("AutoOS", ProcessInfoHelper.Version)
+                }
             }
-        }
         };
 
         public static async Task<(string newestVersion, string newestDownloadUrl)> CheckUpdate(GpuInfo gpu)
diff --git a/Helpers/Games/CitronHelper.cs b/Helpers/Games/CitronHelper.cs
@@ -67,7 +67,7 @@ public static async Task LoadGames()
                 string cleanName = CleanNameRegex().Replace(name.Replace('’', '\''), "");
 
                 // get install location
-                string installLocation = CitronEntry.GetProperty("file_path").GetString();
+                string installLocation = CitronEntry.GetProperty("file_path").GetString()?.Replace("/", "\\");
 
                 // get playtime
                 string playTime = "0m";
@@ -99,8 +99,8 @@ public static async Task LoadGames()
                     GamesPage.Instance.Games.Items.Add(new Views.Settings.Games.HeaderCarouselItem
                     {
                         Launcher = "Citron",
-                        LauncherLocation = localSettings.Values["CitronLocation"]?.ToString(),
-                        DataLocation = localSettings.Values["CitronDataLocation"]?.ToString(),
+                        LauncherLocation = localSettings.Values["CitronLocation"]?.ToString()?.Replace("/", "\\"),
+                        DataLocation = localSettings.Values["CitronDataLocation"]?.ToString()?.Replace("/", "\\"),
                         GameLocation = installLocation,
                         InstallLocation = Path.GetDirectoryName(installLocation),
                         Title = name,
diff --git a/Helpers/Games/EdenHelper.cs b/Helpers/Games/EdenHelper.cs
@@ -68,7 +68,7 @@ public static async Task LoadGames()
                 string cleanName = CleanNameRegex().Replace(name.Replace('’', '\''), "");
 
                 // get install location
-                string installLocation = edenEntry.GetProperty("file_path").GetString();
+                string installLocation = edenEntry.GetProperty("file_path").GetString()?.Replace("/", "\\");
 
                 // get playtime
                 string playTime = "0m";
@@ -100,8 +100,8 @@ public static async Task LoadGames()
                     GamesPage.Instance.Games.Items.Add(new Views.Settings.Games.HeaderCarouselItem
                     {
                         Launcher = "Eden",
-                        LauncherLocation = localSettings.Values["EdenLocation"]?.ToString(),
-                        DataLocation = localSettings.Values["EdenDataLocation"]?.ToString(),
+                        LauncherLocation = localSettings.Values["EdenLocation"]?.ToString()?.Replace("/", "\\"),
+                        DataLocation = localSettings.Values["EdenDataLocation"]?.ToString()?.Replace("/", "\\"),
                         GameLocation = installLocation,
                         InstallLocation = Path.GetDirectoryName(installLocation),
                         Title = name,
diff --git a/Helpers/Games/EpicGamesHelper.cs b/Helpers/Games/EpicGamesHelper.cs
@@ -640,9 +640,9 @@ public static async Task LoadGames()
                             CatalogNamespace = catalogNamespace,
                             CatalogItemId = catalogItemId,
                             AppName = itemJson["MainGameAppName"]?.GetValue<string>(),
-                            InstallLocation = itemJson["InstallLocation"]?.GetValue<string>(),
+                            InstallLocation = itemJson["InstallLocation"]?.GetValue<string>()?.Replace("/", "\\"),
                             LaunchCommand = itemJson["LaunchCommand"]?.GetValue<string>(),
-                            LaunchExecutable = itemJson["LaunchExecutable"]?.GetValue<string>(),
+                            LaunchExecutable = itemJson["LaunchExecutable"]?.GetValue<string>()?.Replace("/", "\\"),
                             ProcessNames = itemJson["ProcessNames"]?.AsArray().Select(p => p.GetValue<string>()).ToList(),
                             ArtifactId = artifactId,
                             UpdateIsAvailable = latestVersion != null && latestVersion != currentVersion,
diff --git a/Helpers/Games/RyujinxHelper.cs b/Helpers/Games/RyujinxHelper.cs
@@ -98,7 +98,7 @@ public static async Task LoadGames()
                     {
                         var simpleFileName = SimpleCleanNameRegex().Replace(Path.GetFileNameWithoutExtension(candidate).ToLowerInvariant(), "");
                         return simpleFileName.StartsWith(simpleCleanName, StringComparison.Ordinal);
-                    }));
+                    }))?.Replace("/", "\\");
                     if (bestInstallLocation != null)
                         break;
                 }
@@ -135,8 +135,8 @@ public static async Task LoadGames()
                     GamesPage.Instance.Games.Items.Add(new Views.Settings.Games.HeaderCarouselItem
                     {
                         Launcher = "Ryujinx",
-                        LauncherLocation = localSettings.Values["RyujinxLocation"]?.ToString(),
-                        DataLocation = localSettings.Values["RyujinxDataLocation"]?.ToString(),
+                        LauncherLocation = localSettings.Values["RyujinxLocation"]?.ToString()?.Replace("/", "\\"),
+                        DataLocation = localSettings.Values["RyujinxDataLocation"]?.ToString()?.Replace("/", "\\"),
                         GameLocation = bestInstallLocation,
                         InstallLocation = Path.GetDirectoryName(bestInstallLocation),
                         Title = name,
diff --git a/Helpers/Games/SteamHelper.cs b/Helpers/Games/SteamHelper.cs
@@ -258,7 +258,7 @@ public static async Task LoadGames()
                                     .Select(s => s.GetProperty("path_thumbnail").GetString())
                                     .Where(s => !string.IsNullOrWhiteSpace(s))]
                                 : [],
-                            InstallLocation = Path.Combine(steamAppsDir, "common", appManifestData["installdir"]?.ToString()),
+                            InstallLocation = Path.Combine(steamAppsDir, "common", appManifestData["installdir"]?.ToString()).Replace("/", "\\"),
                             ReleaseDate = releaseDate.ToString("d"),
                             Size = sizeBytes >= 1024 * 1024 * 1024
                                 ? $"{sizeBytes.Value / (1024d * 1024d * 1024d):F1} GB"
diff --git a/README.md b/README.md
@@ -79,6 +79,7 @@ AutoOS is a WinUI 3 application that automates Windows setup and optimization wi
 - Toggle Windows Security Options
 - Toggle Windows Updates and set target version
 - Custom Game Launcher supporting Epic Games, Steam, Riot Games, Eden, Citron and Ryujinx
+- Check for Epic Games title updates
 - Launch Games, Stop Processes and Restart Processes when done  
 - Switch between Epic Games and Steam Accounts
 
@@ -256,7 +257,7 @@ Clone the repository and run this in the terminal inside of Visual Studio.
 dotnet nuget add source https://pkgs.dev.azure.com/dotnet/CommunityToolkit/_packaging/CommunityToolkit-Labs/nuget/v3/index.json -n CommunityToolkit-Labs
 ```
 
-If the debugger is not attaching to the process you are required to set EnableLua to 0. This has been a problem for 5 years and Microsoft hasn't provided a fix:
+If the debugger is not attaching to the process, you are required to set EnableLua to 0 and restart your PC. This has been a problem for 5 years and Microsoft hasn't provided a fix:
 ```bat
 reg add "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Policies\System" /v EnableLUA /t REG_DWORD /d 0 /f
 ```
diff --git a/Views/Installer/GraphicsPage.xaml.cs b/Views/Installer/GraphicsPage.xaml.cs
@@ -89,9 +89,10 @@ public void GetGpus()
             catch { }
         }
 
-        var detected = GpuHelper.GetGPUs();
+        var detectedGpus = GpuHelper.GetGPUs();
+        detectedGpus = detectedGpus.OrderBy(g => g.Location).ToList();
 
-        foreach (var gpu in detected)
+        foreach (var gpu in detectedGpus)
         {
             var saved = savedGpus?.FirstOrDefault(x => x.PnPDeviceId == gpu.PnPDeviceId);
 
diff --git a/Views/Installer/Stages/NetworkStage.cs b/Views/Installer/Stages/NetworkStage.cs
@@ -1,6 +1,8 @@
-﻿using AutoOS.Views.Installer.Actions;
+﻿using AutoOS.Helpers.Device;
+using AutoOS.Views.Installer.Actions;
 using Microsoft.UI.Xaml.Media;
 using WinRT.Interop;
+using Microsoft.Win32;
 
 namespace AutoOS.Views.Installer.Stages;
 
@@ -44,8 +46,8 @@ public static async Task Run()
             // disable power management settings
             ("Disabling power management settings", async () => await ProcessActions.RunPowerShellScript("networkpowermanagement.ps1", ""), null),
 
-             // set txintdelay to 0
-            ("Setting TxIntDelay to 0", async () => await ProcessActions.RunPowerShellScript("txintdelay.ps1", ""), () => TxIntDelay == true),
+            // set txintdelay to 0
+            ("Setting TxIntDelay to 0", async () => DeviceHelper.GetDevices(DeviceType.NIC).Where(d => Registry.LocalMachine.OpenSubKey(d.RegistryPath).GetValue("TxIntDelay") != null).ToList().ForEach(d => Registry.LocalMachine.OpenSubKey(d.RegistryPath, true).SetValue("TxIntDelay", 0, RegistryValueKind.DWord)), () => TxIntDelay == true),
 
             // set "congestion control provider" to "bbr2"
             (@"Setting ""Congestion Control Provider"" to ""BBR2""", async () => await ProcessActions.RunNsudo("TrustedInstaller", @"netsh int tcp set supplemental internet congestionprovider=bbr2"), null),
diff --git a/Views/Installer/Stages/PreparingStage.cs b/Views/Installer/Stages/PreparingStage.cs
@@ -4,7 +4,6 @@
 using Microsoft.UI.Xaml.Media;
 using Microsoft.Win32;
 using System.Diagnostics;
-using System.Text.Json;
 using System.Text.Json.Nodes;
 using System.Text.RegularExpressions;
 using ValveKeyValue;
@@ -324,7 +323,7 @@ await Task.Run(async () =>
             var nics = DeviceHelper.GetDevices(DeviceType.NIC);
             Wifi = nics.Any(device => device.NicType == NicDeviceType.WiFi);
 			TxIntDelay = nics.Any(device => Registry.LocalMachine.OpenSubKey(device.RegistryPath).GetValue("TxIntDelay") != null);
-			NetAdapterCx = nics.Any(device => device.IsActive && device.DriverType == NicDriverType.NetAdapterCx);
+            NetAdapterCx = nics.Any(device => device.IsActive && device.DriverType == NicDriverType.NetAdapterCx);
         });
 
         InstallPage.Info.Severity = InfoBarSeverity.Informational;
diff --git a/Views/Settings/Games/HeaderCarousel.cs b/Views/Settings/Games/HeaderCarousel.cs
@@ -1375,7 +1375,7 @@ private async void Link_Click(object sender, RoutedEventArgs e)
         {
             if (!string.IsNullOrEmpty(item.Hyperlink))
             {
-                await Windows.System.Launcher.LaunchFolderPathAsync(item.Hyperlink.Replace("/", "\\").Trim());
+                await Windows.System.Launcher.LaunchFolderPathAsync(item.Hyperlink.Trim());
             }
         }
     }
diff --git a/Views/Settings/GraphicsPage.xaml.cs b/Views/Settings/GraphicsPage.xaml.cs
@@ -35,7 +35,7 @@ private async void GraphicsPage_Loaded(object sender, RoutedEventArgs e)
     public void GetGpus()
     {
         var detectedGpus = GpuHelper.GetGPUs();
-
+        detectedGpus = detectedGpus.OrderBy(g => g.Location).ToList();
         GPUs.Clear();
 
         foreach (var gpu in detectedGpus)

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	`using AutoOS.Views.Installer.Actions;`
`2`	`2`	`using System.Diagnostics;`
`3`		`-using System.Net;`
`4`	`3`	`using System.Net.Security;`
`5`	`4`	`using System.Text.Json;`
`6`	`5`	`using Windows.Win32.System.Power;`
`7`	`6`	`using Windows.Win32;`
`8`		`-`
	`7`	`+using System.Net.Http.Headers;`
	`8`	`+using System.Security.Authentication;`
`9`	`9`	`namespace AutoOS.Helpers.GPU`
`10`	`10`	`{`
`11`	`11`	`public static class NvidiaHelper`
`@@ -14,17 +14,17 @@ public static class NvidiaHelper`
`14`	`14`	`{`
`15`	`15`	`SslOptions = new SslClientAuthenticationOptions`
`16`	`16`	`{`
`17`		`- EnabledSslProtocols = System.Security.Authentication.SslProtocols.Tls12 \| System.Security.Authentication.SslProtocols.Tls13`
	`17`	`+ EnabledSslProtocols = SslProtocols.Tls12 \| SslProtocols.Tls13`
`18`	`18`	`}`
`19`	`19`	`})`
`20`	`20`	`{`
`21`	`21`	`DefaultRequestHeaders =`
`22`		`- {`
`23`		`- UserAgent =`
`24`	`22`	`{`
`25`		`- new System.Net.Http.Headers.ProductInfoHeaderValue("AutoOS", ProcessInfoHelper.Version)`
	`23`	`+ UserAgent =`
	`24`	`+ {`
	`25`	`+ new ProductInfoHeaderValue("AutoOS", ProcessInfoHelper.Version)`
	`26`	`+ }`
`26`	`27`	`}`
`27`		`- }`
`28`	`28`	`};`
`29`	`29`
`30`	`30`	`public static async Task<(string newestVersion, string newestDownloadUrl)> CheckUpdate(GpuInfo gpu)`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ public static async Task LoadGames()`
`98`	`98`	`{`
`99`	`99`	`var simpleFileName = SimpleCleanNameRegex().Replace(Path.GetFileNameWithoutExtension(candidate).ToLowerInvariant(), "");`
`100`	`100`	`return simpleFileName.StartsWith(simpleCleanName, StringComparison.Ordinal);`
`101`		`- }));`
	`101`	`+ }))?.Replace("/", "\\");`
`102`	`102`	`if (bestInstallLocation != null)`
`103`	`103`	`break;`
`104`	`104`	`}`
`@@ -135,8 +135,8 @@ public static async Task LoadGames()`
`135`	`135`	`GamesPage.Instance.Games.Items.Add(new Views.Settings.Games.HeaderCarouselItem`
`136`	`136`	`{`
`137`	`137`	`Launcher = "Ryujinx",`
`138`		`- LauncherLocation = localSettings.Values["RyujinxLocation"]?.ToString(),`
`139`		`- DataLocation = localSettings.Values["RyujinxDataLocation"]?.ToString(),`
	`138`	`+ LauncherLocation = localSettings.Values["RyujinxLocation"]?.ToString()?.Replace("/", "\\"),`
	`139`	`+ DataLocation = localSettings.Values["RyujinxDataLocation"]?.ToString()?.Replace("/", "\\"),`
`140`	`140`	`GameLocation = bestInstallLocation,`
`141`	`141`	`InstallLocation = Path.GetDirectoryName(bestInstallLocation),`
`142`	`142`	`Title = name,`
Original file line number	Diff line number	Diff line change
`@@ -89,9 +89,10 @@ public void GetGpus()`
`89`	`89`	`catch { }`
`90`	`90`	`}`
`91`	`91`
`92`		`- var detected = GpuHelper.GetGPUs();`
	`92`	`+ var detectedGpus = GpuHelper.GetGPUs();`
	`93`	`+ detectedGpus = detectedGpus.OrderBy(g => g.Location).ToList();`
`93`	`94`
`94`		`- foreach (var gpu in detected)`
	`95`	`+ foreach (var gpu in detectedGpus)`
`95`	`96`	`{`
`96`	`97`	`var saved = savedGpus?.FirstOrDefault(x => x.PnPDeviceId == gpu.PnPDeviceId);`
`97`	`98`