Skip to content

Comments

Fix in-memory#97

Merged
timvink merged 7 commits intotimvink:masterfrom
twsl:fix/in-memory
Oct 25, 2024
Merged

Fix in-memory#97
timvink merged 7 commits intotimvink:masterfrom
twsl:fix/in-memory

Conversation

@twsl
Copy link
Contributor

@twsl twsl commented Oct 17, 2024

Fix #91

@twsl
Copy link
Contributor Author

twsl commented Oct 17, 2024

The tests are basically a mess due to how the dependencies are managed. Doesn't help, that mkapi does not expose a version property. If you have additional suggestions, let me know

@twsl twsl marked this pull request as ready for review October 17, 2024 14:42
@twsl
Copy link
Contributor Author

twsl commented Oct 20, 2024

@timvink can we get this merged?

@timvink
Copy link
Owner

timvink commented Oct 20, 2024

Hee, thanks for fixing this!

There is one more thing we should check, there is an attribute for generated files that some plugins use:

https://github.com/mkdocs/mkdocs/pull/3344/files

@twsl
Copy link
Contributor Author

twsl commented Oct 20, 2024

what exactly do you want to check? or just include it to log which plugin might have been the culprit?

@timvink
Copy link
Owner

timvink commented Oct 22, 2024

Your current way to check for generated files is by checking if src_path is None. But that's only true for generated files that are in Memory. Some generated files do have a src_path (written to disk), but no git info.

So extend the check to look for the generated by attribute

@twsl
Copy link
Contributor Author

twsl commented Oct 22, 2024

I hope, this is what you meant, @timvink . If not, maintainers are allowed to edit 😆

@timvink
Copy link
Owner

timvink commented Oct 25, 2024

Thanks again for picking this up and fixing it! 🙏🏻

@timvink timvink merged commit e63bde8 into timvink:master Oct 25, 2024
@timvink timvink mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MkApi 3.x breaks this plugin

2 participants