Fix in-memory#97
Conversation
|
The tests are basically a mess due to how the dependencies are managed. Doesn't help, that |
|
@timvink can we get this merged? |
|
Hee, thanks for fixing this! There is one more thing we should check, there is an attribute for generated files that some plugins use: |
|
what exactly do you want to check? or just include it to log which plugin might have been the culprit? |
|
Your current way to check for generated files is by checking if src_path is None. But that's only true for generated files that are in Memory. Some generated files do have a src_path (written to disk), but no git info. So extend the check to look for the generated by attribute |
|
I hope, this is what you meant, @timvink . If not, maintainers are allowed to edit 😆 |
|
Thanks again for picking this up and fixing it! 🙏🏻 |
Fix #91