fix: determine contribution on page level#78
Merged
timvink merged 1 commit intotimvink:masterfrom Mar 12, 2024
Merged
Conversation
Contributor
Author
Owner
|
Thanks! Can you have a look at the unit tests failing? |
Contributor
Author
|
Locally tests just work? |
ThomasTNO
force-pushed
the
author_percentage_threshold
branch
from
2e7e0e1 to
973172d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted a minor bug in determining whether an author surpasses the contribution threshold, this resolves this issue.
Bug: contribution was computed overall.
Solution: compute contribution on page level.