Conversation
(I don't intend to be nitpicking about whitespace, but without a separate commit the following commits would become dirty).
The "authors" return value should be a list (of author dicts), but in case of failure it returned an empty string. This was incorrectly handled in Util.summarize(), but fortunately with no negative effect: - iterating over a string returns its characters, but - iterating over an empty string behaves like iterating over an empty dict.
Create a cache dictionary, with file paths as key. Util.get_authors() is called twice, and there's no need to call Git twice if we can cache the results.
This has been inadvertently been overwritten by copy/paste
timvink
reviewed
Feb 26, 2020
| total_lines = sum([x.get('lines') for x in authors]) | ||
| for author in authors: | ||
| author['contribution'] = self._format_perc(author['lines'] / total_lines) | ||
| if not authors: |
Owner
There was a problem hiding this comment.
early stopping is a better design pattern that's easier to read, i.e
if authors:
return authors
# rest of the code
return authors
Owner
|
Thanks @uliska ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a warm-up PR to get familiar with the code.
it includes one fix (second commit) and one (perceived) coding improvement (third commit). The initial whitespace commit is only to have the following commits clean.