Skip to content

add more test on all datatype and change test to Timeplus style#20

Merged
chenziliang merged 2 commits intomainfrom
add-more-test
Jun 25, 2024
Merged

add more test on all datatype and change test to Timeplus style#20
chenziliang merged 2 commits intomainfrom
add-more-test

Conversation

@lizhou1111
Copy link
Copy Markdown
Contributor

@lizhou1111 lizhou1111 commented Jun 19, 2024

No description provided.

@lizhou1111 lizhou1111 self-assigned this Jun 19, 2024
yl-lisen
yl-lisen reviewed Jun 19, 2024
View reviewed changes
Comment thread timeplus-native-jdbc/src/test/java/com/github/timeplus/jdbc/AbstractITest.java Outdated
protected static final String DRIVER_CLASS_NAME = "com.github.timeplus.jdbc.TimeplusDriver";

public static final String CLICKHOUSE_IMAGE = System.getProperty("CLICKHOUSE_IMAGE", "ghcr.io/timeplus-io/proton:latest");
public static final String TIMEPLUS_IMAGE = System.getProperty("TIMEPLUS_IMAGE", "ghcr.io/timeplus-io/proton:latest");
Copy link
Copy Markdown

@yl-lisen yl-lisen Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned by Ken ( https://timeplus-workspace.slack.com/archives/C02LT9BMZ2R/p1718420192471869?thread_ts=1718358754.791659&cid=C02LT9BMZ2R) , we should use timeplusd

@yl-lisen
Copy link
Copy Markdown

yl-lisen commented Jun 19, 2024

some data types are missed, such as low_cardinality and json

@lizhou1111
Copy link
Copy Markdown
Contributor Author

lizhou1111 commented Jun 19, 2024

some data types are missed, such as low_cardinality and json

not support json, low_cardinality seems have bug

ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.387 s <<< FAILURE! - in com.github.timeplus.jdbc.type.LowCardinalityTypeTest
[ERROR] testAlllow_cardinalityTypes  Time elapsed: 0.018 s  <<< ERROR!
com.github.timeplus.exception.TimeplusSQLException: 
DB::ExceptionDB::Exception: Invalid version for SerializationLowCardinality key column.. Stack trace:


        at com.github.timeplus.jdbc.type.LowCardinalityTypeTest.lambda$testAlllow_cardinalityTypes$0(LowCardinalityTypeTest.java:60)
        at com.github.timeplus.jdbc.type.LowCardinalityTypeTest.testAlllow_cardinalityTypes(LowCardinalityTypeTest.java:29)

@chenziliang chenziliang merged commit 398766f into main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yl-lisen yl-lisen yl-lisen left review comments

@chenziliang chenziliang Awaiting requested review from chenziliang

Assignees

@lizhou1111 lizhou1111

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lizhou1111 @yl-lisen @chenziliang