perf(proton): remove per-row mutex lock around batched.Append()

yokofly · claude · yokofly · commit 18193a0ebbc6 · 2026-03-30T02:16:07.000-07:00
The ds.Context.Lock()/Unlock() around batched.Append(row...) was unnecessary:
- batched is a local object created in the operation closure
- batchRows is a local snapshot fully drained from the channel
- No concurrent goroutine accesses either during the append loop

This saved 1.66M mutex lock/unlock cycles.

Benchmark (localhost, 1.66M rows, batch_limit=50K, cumulative):
  Baseline:          62s (41.0s user)
  + LZ4:             61s
  + g.Debug removal: 28s (10.5s user)
  + this:            27s ( 9.8s user) ← ~1s improvement

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/core/dbio/database/database_proton.go b/core/dbio/database/database_proton.go
@@ -733,10 +733,8 @@ func (conn *ProtonConn) processBatch(tableFName string, table Table, batch *iop.
 				return backoff.Permanent(err) // Type conversion errors are permanent
 			}
 
-			// Do insert
-			ds.Context.Lock()
+			// Do insert (batched is local to this closure, no concurrent access)
 			err = batched.Append(row...)
-			ds.Context.Unlock()
 			if err != nil {
 				ds.Context.CaptureErr(g.Error(err, "could not insert into table %s, row: %#v", tableFName, row))
 				return g.Error(err, "could not execute statement") // Network/temporary errors can retry
