Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The task creation does not verify the correctness of query and the target. User get no feedback when there is any error until the task is scheduled to execute.
Possible cases when we should abort task creation due to error includes:
ASkeyword) has syntax error and cannot be executed.INTOkeyword beforeASkeyword) does not exist.Propose
Do additional validation on task creation for the task query and target stream. Make sure it can be executed as in src/Task/TaskExecution.h and src/Task/TaskExecution.cpp . If any error, raise an exception with error message.
Related Source Code
under src/Task folder
Test
Add stateless tests for negative cases mentioned above.