fix: correct NATS cmake flag in Docker packager#1130
Merged
Conversation
… ENABLE_NATS) The packager passed -DENABLE_NATSIO=ON but the CMake option is ENABLE_NATS, so the nats-io library was silently skipped and the NATS JetStream connector was never compiled into Docker images. Co-Authored-By: Claude <[email protected]> Made-with: Cursor
yuzifeng1984
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-DENABLE_NATSIO=ONbut the CMake option defined incontrib/nats-io-cmake/CMakeLists.txtisENABLE_NATSUSE_NATSIOwas never set — the NATS JetStream connector (#if USE_NATSIOguards) was compiled out of all Docker imagesENABLE_NATSIOtoENABLE_NATSindocker/packager/packagerContext
Introduced in d28c604 ("add nats-io submodule") which was part of PR #1117. The JetStream connector itself (PR #1111) is correct — only the packager flag name was wrong.
Test plan
CREATE EXTERNAL STREAM ... SETTINGS type='nats_jetstream'no longer returnsNOT_IMPLEMENTEDin the new imageMade with Cursor