tests/ported-clickhouse-test.py:1

• pool.join() is called after the pool has gone out of scope in the with closing(...) block in the new structure (and, importantly, closing only calls pool.close() on __exit__). As written, pool.join() is also effectively associated with a pool that may not have been properly closed before joining, which can raise ValueError: Pool is still running depending on execution flow. The simplest fix is to move pool.join() back outside the with (like the previous version) so closing closes the pool first, or explicitly call pool.close() before pool.join() while still inside the with.
  tests/ported-clickhouse-test.py:1
• In the macOS thread-based path, submitted tasks' exceptions will be silently stored in their Futures and never surfaced because the futures are not collected/awaited. This can lead to false-green runs where workers fail early but the main thread never sees the error. Prefer executor.map(...) or store the returned futures and call future.result() (or concurrent.futures.wait(...) + result()) to propagate exceptions.
  src/Bootstrap/ServerDescriptor.cpp:1
• This change drops support for the legacy keys (tcp.port, tcp_secure.port, http.port, https.port, etc.) that were previously accepted. If existing deployments/configs still use the legacy layout, they will now silently fall back to the defaults (8463/3218/...) and effectively ignore the configured ports. Consider keeping backward-compatible reads (e.g., check node.* first, then fall back to the prior keys) so this isn’t a breaking config change.
  src/CPython/tests/CPythonTest.h:1
• The buffer returned by Py_DecodeLocale must remain valid for the lifetime of the interpreter (Python expects the program name string to outlive initialization), but it also must be freed (typically with PyMem_RawFree) after Py_Finalize(). The current code sets the program name and then discards the pointer, which causes a leak and makes it impossible to clean up correctly. Store the decoded wchar_t* in a static and free it in TearDownTestSuite() after Py_Finalize(), or avoid Py_DecodeLocale and use a managed lifetime approach consistent with the embedded-Python guidance.
  tests/queries_ported/0_stateless/00534_functions_bad_arguments.lib:1
• Executing $CLICKHOUSE_CLIENT inside Perl qx{...} runs via a shell command string; if $CLICKHOUSE_CLIENT contains spaces/flags or unexpected characters, this can break the command or become a shell-injection vector in test environments. Prefer invoking a known-safe client binary (as before) or ensure $CLICKHOUSE_CLIENT is a single executable path and pass arguments safely (e.g., by avoiding qx{...} with interpolated shell strings).
  local_coverage.sh:1
• || true forces _run_unit_tests to always succeed, which makes it impossible for callers to detect unit test failures (even if they try to capture $?). If you want to keep collecting coverage without aborting, capture the exit code into a variable and return it explicitly (or record it for the final summary) instead of unconditionally masking failures.

tests/queries_ported/0_stateless/00534_functions_bad_arguments.lib:1

• qx{...} is executed by Perl, so $CLICKHOUSE_CLIENT is interpreted as a Perl scalar (likely empty), not the shell environment variable. This will run an invalid command and can cause the test to fail. Use a literal client binary (as before), or reference the environment explicitly via $ENV{CLICKHOUSE_CLIENT} / $ENV{...} (with appropriate quoting/escaping for spaces).
  tests/ported-clickhouse-test.py:1
• In non-main threads, signal.signal(...) raises ValueError, which means the os.killpg(...) line is never reached (the exception happens before it). This can prevent stop_tests() from actually terminating the test process group when running under the macOS thread executor. A minimal fix is to only call signal.signal(...) in the main thread (or move os.killpg(...) before those calls), so the process group termination still happens in worker threads.
  src/Bootstrap/ServerDescriptor.cpp:1
• This removes support for the prior config keys (tcp.port, tcp_secure.port, http.port, https.port, etc.). If existing deployments still use the legacy keys, they will silently fall back to defaults (or ignore configured secure ports), which is a breaking configuration change. Consider supporting both schemas (prefer node.*, fallback to legacy keys) or emitting a clear error/warning when legacy keys are detected.
  src/CPython/tests/CPythonTest.h:1
• Py_DecodeLocale() allocates memory that should be released with PyMem_RawFree() at teardown (and Python expects the program name buffer to remain valid for the interpreter lifetime). Right now the pointer is not stored anywhere, so it can’t be freed and will leak for the duration of the test process. Store the decoded pointer in a static and free it in TearDownTestSuite() after Py_Finalize().