bugfix: fix _tp_delta missing in streaming agg#1118
Merged
Conversation
* Fix missing _tp_delta in streaming aggregation * Address PR review comments 1. Fix typo in FIXME comment: 'requries' -> 'requires' 2. Fix os.setpgid error handling to prevent killpg issues: - Check if process is group leader before calling killpg - Use os.getpgrp() == os.getpid() to avoid race conditions - Handle OSError exceptions gracefully Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
Contributor
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing _tp_delta in streaming aggregation
Address PR review comments
PR checklist:
proton: starts/endsfor new code in existing community code base ?Please write user-readable short description of the changes: