Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 179c6cc11b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d update) (#11324) * ClickHouse/ClickHouse#63865 from azat/fix-query-profiler-SIGSEGV Fix SIGSEGV due to CPU/Real profiler * ClickHouse/ClickHouse#60468 from ClickHouse/libunwind-fix-crash Fix crash in libunwind while interpreting debug info * ClickHouse/ClickHouse#65509 Update libunwind to 18.1.7 * ClickHouse/ClickHouse#66850 from ClickHouse/revert-libunwind-patch Revert libunwind patch * ClickHouse/ClickHouse#66977 from ClickHouse/uwo Apply libunwind fix * ClickHouse/ClickHouse#68312 from ClickHouse/muslwind Apply libunwind changes needed for musl * ClickHouse/ClickHouse#76107 from ClickHouse/owo Apply libunwind fix for DwarfFDECache * ClickHouse/ClickHouse#76136 from ClickHouse/revert-76107-owo Revert "Apply libunwind fix for DwarfFDECache" * ClickHouse/ClickHouse#76178 from ClickHouse/unw Apply libunwind fix for DwarfFDECache, attempt 2 * Update libunwind to aec8e58 * ClickHouse/ClickHouse#67152 from ClickHouse/ohno Uncomment accidentally commented out code in QueryProfiler * ClickHouse/ClickHouse#64058 aarch64 sigaltstack size fix * ClickHouse/ClickHouse#58607 Added null guards to avoid potential demangle crashes --------- Co-authored-by: Nikita Mikhaylov <[email protected]> Co-authored-by: Alexey Milovidov <[email protected]> Co-authored-by: Michael Kolupaev <[email protected]> Co-authored-by: Antonio Andelic <[email protected]> Co-authored-by: Max Kainov <[email protected]>
Co-authored-by: Alexey Milovidov <[email protected]>
yokofly
force-pushed
the
port-storage-enhance-and-correct-query-profiler
branch
from
179c6cc to
697d062
Compare
Collaborator
Author
|
@codex review |
yokofly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included:
submodule.
SEGV_PKUERR crashes. downgrade v8 to lts 138 ver #1017
--prefix, avoids mixed/duplicate setuptools state).