Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
To use Codex here, create a Codex account and connect to github. |
Collaborator
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please write user-readable short description of the changes:
fix #1079
old:
new:
The difference is the word "incremental" in the log message:
Old (broken):
RocksCheckpoint: Took 12 ms to materialized rocks ckpt to ...
New (fixed):
RocksCheckpoint: Took 10 ms to materialized incremental rocks ckpt to ...
The old version was ignoring the incremental=true setting and always doing full checkpoints. Now correctly enables incremental checkpointing for epoch 2+.