Add support for TimberPost->terms( array ) & more #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few things (sorry about that) but I tried to limit the reach of the code changed to only that which is relevant. I think the commit messages give a pretty good summary, but here's the gist of it:
terms/get_termsmethods on aTimberPostand passing an array of taxonomies to fetch terms for, rather than all of them.termsas well as tags and categories to be cleaner and more readableTimberTerm, which takes the same arguments as the constructor method. Usage likeTimberTerm::from('My Term Name'). This is also totally compatible with extended classes.MyExtendedTimberTerm::from('My Term Name')_get_termsproperty and deprecate it onTimberPost. This cache is not only unnecessary, but could actually return the wrong results as it only caches based on the taxonomy argument, and did not take the other method arguments into consideration.