Skip to content

Conversation

@baglio
Copy link
Contributor

@baglio baglio commented May 7, 2024

Issue

The current $block variable in the docs for the my_acf_block_render_callback does not exists, resulting in an error.

Solution

Replaced $block['name'] with $attributes['name'].

@baglio baglio requested a review from gchtr as a code owner May 7, 2024 15:46
Copy link
Member

@Levdbas Levdbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @baglio! I added one small suggestion. You can add that to if you think it's a good addition.

Co-authored-by: Erik van der Bas <[email protected]>
@baglio
Copy link
Contributor Author

baglio commented May 7, 2024

@Levdbas of course. Did I incorporate your suggestion correctly?

@Levdbas Levdbas merged commit 54ed1e5 into timber:2.x May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unknown variable $block in my_acf_block_render_callback; wrong variable used in the docs.

2 participants