-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x Prepare 2.0 release #2829
2.x Prepare 2.0 release #2829
Conversation
Co-authored-by: Erik van der Bas <[email protected]>
Yes, we still need to prepare for that. I mainly need to work on this in the https://github.com/timber/docs repository. I thought about moving the /v2/ slug to the main docs path (https://timber-docs.test/docs/). But then, all existing links that specifically link to v2 documentation will not work anymore. We would have to create redirects for those (complicated). And also, all links to v1 docs wouldn’t lead to the intended page. The solution I think would work better is to keep the version in the path. The Laravel Documentation already does something similar (e.g. with a link To make this work well, the following steps are needed:
|
Let me know if you need some help with that @gchtr |
Thanks for offering your help. I will create a pull request in the docs repo that you can then test in a local environment. |
@Levdbas I’ve created a pull request in timber/docs#80. I’d be happy if you could check that out! |
Another fix in d7163f1 to make the section archives work, see timber/docs#80 (comment). |
Related:
Issue
Right before releasing 2.0, we should update the documentation.
Solution
Prepare the changes.
Impact
None.
Usage Changes
None.
Considerations
None.
Testing
No.