2.x Fix some small issues in Getting Started docs #2761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levdbas
approved these changes
May 31, 2023
Member
Levdbas
left a comment
Levdbas
left a comment
There was a problem hiding this comment.
Great work! I never knew about the no_found_rows optimization to be honest. I learned something!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
I initially wanted to add test for the different code snippets. But this seems a little too tedious. Most of the functionality used there is already tested elsewhere.
Still, I found some details to fix.
Solution
Fix some smaller issues.
Impact
None.
Usage Changes
None.
Considerations
None.
Testing
No.