Remove audio & video methods from Post
#2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those methods do not really make sense. Since `Post` is kind of a DTO object, it should not extract html content from `post_content`.
nlemoine
changed the title
Post
Levdbas
approved these changes
May 26, 2023
gchtr
added a commit
that referenced
this pull request
May 29, 2023
Levdbas
added a commit
that referenced
this pull request
May 30, 2023
2.x Update Upgrade Guide for #2750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I'm rushing before RC to try to get rid of things that I would really don't want to see anymore in Timber and that's my last chance to introduce breaking changes 🙂
Feel free to disagree of course ;)
Issue
Those methods do not really make sense. Since
Postis kind of a DTO object, it should not extract html content frompost_content. Theoretically, this would mean we could have some methods likeparagraphs()orheadings().Solution
Remove them.
Impact
Yes, methods aren't available anymore.
Usage Changes
No more
{{ post.audio }}or{{ post.video }}Considerations
If users asks for these, we could introduce more generic filters to extract some HTML from content.