2.x Fix PHPStan issues on level 0 #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2022
This was referenced Nov 4, 2022
Member
Author
|
I think we can ignore the decreased coverage. Some of it is caused by return types that should become stale again when #2669 is merged. I’m marking this ready for review. |
gchtr
added
the
Ready for Review
nlemoine
approved these changes
Jan 24, 2023
Member
Author
|
@nlemoine Thanks for the review! I’m merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are various issues raised by PHPStan on level 0.
Solution
This pull request resolves some of them. Other issues will be resolved in separate pull requests.
Impact
More robust code.
Usage Changes
Some return type changes.
Considerations
Testing
Should be covered through existing tests.
Except the new return types, which we should add tests for. Coverage shrinked because of this.
Todo