Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timber::get_calling_script_file backtrace doesn't necessarily reference a file #785

Closed
gwagroves opened this issue Dec 11, 2015 · 1 comment
Closed

Timber::get_calling_script_file backtrace doesn't necessarily reference a file #785

gwagroves opened this issue Dec 11, 2015 · 1 comment

Comments

@gwagroves
Copy link
Contributor

https://github.com/jarednova/timber/blob/master/timber.php#L608

The if clause assumes that the file key exists, but file is only a possible key. (A callable is listed in the backtrace without file being set, causing an undefined index notice to be triggered.)

Solution: use array_key_exists.
gwagroves added a commit to gwafork/timber that referenced this issue Dec 11, 2015
@gwagroves
timber#785 add array_key_exists to get_calling_script_file
d0ca887
@prisis prisis mentioned this issue Dec 16, 2015
Closed
@connorjburton
Copy link

Closing as this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gwagroves @connorjburton