-
-
Notifications
You must be signed in to change notification settings - Fork 511
Description
This is an overview issue for the release of version 2.0 of Timber. If you find questions about the release of Timber 2.0, guide them here.
Roadmap
The next steps for a 2.0 release are:
- Release second beta
2.0.0-beta.2by the end of this week - Work through open pull requests and issues. Triage issues and pull requests that are not critical for the 2.0 release.
- First release candidate
2.0.0-rc.1by June/July 2023 - Release Timber 2.0 one to two months after developers could test out the release candidate.
🚀 Check out the Release notes.
The past has shown us that it’s difficult to predict an exact ETA. And with our limited resources, we don’t want to make promises we can’t keep. But let’s work towards a 2.0 release by being strict about what we really need for a 2.0 release and what we can postpone for later.
Help is welcome from everyone, also developers who are not maintainers. If you can provide insights, spot issues in the pull requests and comment on these, you’ll help us move the project forward.
Pull requests
The following pull requests need to be reviewed and resolved.
- 2.x Remove unneeded Timber\Image::is_image() method #2669
- Fix
PostFactory::is_imageincorrectly usingwp_check_filetype#2730 - 2.x Make object constructors final #2660
- 2.x Fix PHPStan issues on level 1 #2667
- 2.x Fix PHPStan issues on level 2 #2668
- Fix custom field test #2749
- Remove audio & video methods from
Post#2750 - Remove unused private property #2751
- 2.x cs imports #2700
- Refactor file models #2753
For each of these pull requests we should decide whether we can solve them in the future or whether we really need to solve them for a first 2.0 release. By "future", we mean that we can decide whether:
- The issue can be resolved in a minor version of Timber 2.x, so 2.1 or 2.2, etc.
- The issue will have to wait for Timber 3.x.
Postponed issues and pull requests
- 2.x Fix menu location compatibility with WPML #2733 (postponed to
2.x Future) - Timber 2.x - ImageHelper::theme_url_to_dir() returns an invalid path when theme template is theme-name/theme #2453 (postponed to
2.x Future) - 2.x Add ImageHelper filters to customize paths #2725 (postponed to
2.x Future) - [BUG] symfony/cache-extra and timber 2, cache method unclear #2762 (postponed to
2.x Future)
Outstanding issues
- Update Starter Theme for 2.x #1784 – Is possibly resolved already and can be closed.
- [BUG] URLHelper::is_external() false-positive #2766
- [BUG] toWebP() causes Uncaught TypeError: imageistruecolor(): Argument #1 ($image) must be of type GdImage, null given Error #2771
- Link Checker Report #2745
Issues with patches
This issues have patches and will be resolved when their corresponding pull requests are resolved.
- Source code contains to be resolved issues "todos" #2626
- [BUG] Deprecation Notice implicit conversion from float to int in ImageDimensions.php #2772
- is_image() function not working with URL params appended to an image src #2444
- Timezone Errors with post dates #2737
- Test code snippets in Getting Started section #2278
After release
- Make the 2.x branch the default one
- Make a 1.x branch
- Undo 2.x Add note about installing the release candidate #2796. See 2.x Prepare 2.0 release #2829
- Make the v2 docs the default docs
- Make a change in https://timber.github.io/docs/getting-started/setup/ on how to install the v1 version for legacy purposes. See 2.x Prepare 2.0 release #2829.
- Update the upgrade guide to link to the migration guide to switch to the composer version of Timber v1
- Update readme.md in both branches to refer to eachother. As an example see:

