Fix: timber::get_menu(0) returns alphabetically first menu instead of nothing (#3070)

Levdbas · web-flow · commit d278f954f672 · 2024-12-18T05:22:17.000+01:00
* fix: Timber::get_menu(int 0) will now return null instead of a alphabetically first menu available
* docs: enhance menu retrieval example in the documentation
diff --git a/docs/v2/guides/menus.md b/docs/v2/guides/menus.md
@@ -166,14 +166,8 @@ add_filter('timber/context', 'add_to_context');
 function add_to_context($context)
 {
     // Set all nav menus in context.
-    foreach (array_keys(get_registered_nav_menus()) as $location) {
-        // Bail out if menu has no location.
-        if (!has_nav_menu($location)) {
-            continue;
-        }
-
+    foreach (array_keys(get_nav_menu_locations()) as $location) {
         $menu = Timber::get_menu($location);
-
         $context[$location] = $menu;
     }
 
diff --git a/src/Factory/MenuFactory.php b/src/Factory/MenuFactory.php
@@ -105,6 +105,10 @@ public function from_location(string $location, array $args = []): ?Menu
      */
     public function from_id(int $id, array $args = []): ?Menu
     {
+        if (0 === $id) {
+            return null;
+        }
+
         $term = \get_term_by('id', $id, 'nav_menu');
 
         if (!$term) {
