Docker delete volumes #6594
Merged
Docker delete volumes #6594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanMBrennan
force-pushed
the
feature/deleteVolumes
branch
from
e47d99b to
9a24286
Compare
Contributor
Author
|
nvm, force pushed another rebase to trigger the CI pipeline. |
… docker compose projects only. Signed-off-by: Sean Brennan <[email protected]>
Signed-off-by: Sean Brennan <[email protected]>
SeanMBrennan
force-pushed
the
feature/deleteVolumes
branch
from
9a24286 to
590b67b
Compare
Member
|
i like this proposal but now everyone is going to complain that --delete-volumes=false will delete kubernetes volumes. but maybe someone can do that later 😂 |
Member
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '--delete-volumes' option to
tilt downthat removes volumes for docker compose projects only.docker compose downdoes not remove internal volumes without a '-v|--volumes' option. This change adds that option iftilt downis called with an additional '--delete-volumes' option.Tested and working as expected.